Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle actOn dispatch correctly in replace items #751

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix: handle actOn dispatch correctly in replace items #751

merged 1 commit into from
Jun 10, 2024

Conversation

jd1378
Copy link
Contributor

@jd1378 jd1378 commented May 24, 2024

resolves #750

@jd1378
Copy link
Contributor Author

jd1378 commented Jun 4, 2024

hi @fratzinger
can we have this merged and released ?

@fratzinger fratzinger merged commit 26850b5 into feathersjs-ecosystem:master Jun 10, 2024
7 checks passed
@fratzinger
Copy link
Collaborator

Released as v8.1.3 🎉 Thanks for the change. Sorry for the delay and thanks for the ping 👍
Would you be up to add tests for this?

@jd1378
Copy link
Contributor Author

jd1378 commented Jun 10, 2024

Hi
thanks for the release
check #752 for tests
I tried it by reverting the change locally and the test fails, so it should be good

@jd1378 jd1378 mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update replaceItems util to support pagination on dispatch
2 participants
@jd1378 @fratzinger