-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Funda project | pull request | Larissa Mikkers #21
Open
Lmikkers
wants to merge
50
commits into
fdnd-agency:main
Choose a base branch
from
Lmikkers:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
995e9e4
nav toegevoegd
Lmikkers c7b3eb7
nav aangepast + content erbij
Lmikkers a34af80
nav aangepast style + html
Lmikkers f33a88f
div naar ul li menu
Lmikkers 294538b
nav aangepast
Lmikkers 6e36ba2
header images grid template
Lmikkers 19c943d
content aangepast
Lmikkers 160a538
tabel opmaak
Lmikkers 8f7df44
icons toegevoegd + tabel gefixt + lees meer
Lmikkers ab1af37
readmore
Lmikkers 79c4d4d
Update index.html
Lmikkers 907fa99
Update index.html
Lmikkers 2464b73
Update index.html
Lmikkers 6fd8e83
image slider aangepast
Lmikkers 3a3deac
ing stukje erbij en woning waarde
Lmikkers 82a5ca2
huis waarden + content toegevoegd onder
Lmikkers e34208c
activity add
Lmikkers b05845c
buurt toegevoed + new label
Lmikkers 6782025
buurt
Lmikkers d2d09e8
in de buurt html css
Lmikkers 3d9c084
map toegevoegd
Lmikkers bc25711
reistijd toegevoegd
Lmikkers 509d4f5
vergelijkbaar buurt toegevoegd
Lmikkers 0ef72e0
sidebar toegevoegd
Lmikkers 7912e77
sidebar aangepast + container
Lmikkers 5cc5b25
issues alt img opgelost
Lmikkers 1259f3a
action even weggehaald form
Lmikkers 43552b7
Footer toegevoegd + sidebar css
Lmikkers 33eb23c
gridContainer margin aangepast
Lmikkers a91a3f3
Update style.css
Lmikkers 00d0e51
!important toegevoegd container
Lmikkers 0eb4e1e
pagina lijst einde aangepast responsive
Lmikkers f6e2156
sidebar gefixt
Lmikkers a3912ee
Update style.css
Lmikkers d7330a9
em naar rem
Lmikkers efa1aa3
html css netjes gemaakt
Lmikkers 1424626
kleine aanpassingen + JS
Lmikkers ee4d72f
Update README.md
Lmikkers ee32570
Update README.md
Lmikkers 5f07dab
Update README.md
Lmikkers 0465820
Update README.md
Lmikkers 3a237ac
Update README.md
Lmikkers 2df12b1
Update README.md
Lmikkers f67af89
Update README.md
Lmikkers f01d4c0
Update README.md
Lmikkers 2c226e4
Update README.md
Lmikkers 83f587b
Update README.md
Lmikkers b2f0faf
Update README.md
Lmikkers 561e6fa
Update README.md
Lmikkers b4c391a
Update README.md
Lmikkers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"liveServer.settings.port": 5501 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,80 @@ | ||
<img width="123" alt="image" src="https://github.com/fdnd-agency/funda/assets/1061632/971b90d8-5c19-46a1-a19c-5414aee155c3"> | ||
# Funda Design Challenge Sprint 6 | ||
|
||
# Projecten | ||
<img src="https://github.com/Lmikkers/funda/assets/94455811/60f4b070-09ce-48e2-8338-ccde900e7967"> | ||
https://lmikkers.github.io/funda/ | ||
|
||
* Jaar 1: [Design Challenge Sprint 6](https://github.com/fdnd-agency/funda/blob/main/design-challenge-sprint-6/README.md) | ||
* Jaar 2: [Favourite Houses](https://github.com/fdnd-agency/funda/blob/main/favourite-houses/README.md) | ||
|
||
## Inhoudsopgave | ||
- [Opdrachtgever](https://github.com/Lmikkers/funda/blob/main/README.md#opdrachtgever) | ||
- [Gebruik website](https://github.com/Lmikkers/funda/blob/main/README.md#gebruik-van-website) | ||
- [Kenmerken](https://github.com/Lmikkers/funda/blob/main/README.md#kenmerken) | ||
- [Checklist](https://github.com/Lmikkers/funda/blob/main/README.md#checklist-pagina) | ||
|
||
## Opdrachtgever | ||
### Funda | ||
Funda is een vastgoedplatform voor consumenten en ondernemers. Via Funda kun je huizen kopen, verkopen en huren. | ||
|
||
Opdrachtomschrijving | ||
|
||
> Het maken (nabouwen) van een detailpagina en verbeteren waar nodig is in hardcode vanille html, css en javascript. En ervoor zorgen dat de code mobile first wordt gebouwd. | ||
|
||
## Gebruik van website | ||
Je kunt de website op Telefoon, Tablet en desktop openen op deze link: https://lmikkers.github.io/funda/ | ||
[https://lmikkers.github.io/funda/](https://lmikkers.github.io/funda/) | ||
|
||
## Kenmerken | ||
- HTML | ||
- CSS | ||
- Responsive | ||
|
||
### HTML | ||
Structuur: `<header>` `<main>` `<footer>` | ||
|
||
Onderverdeeld in: `<nav>` `<section>` `<article>` `<div>` | ||
|
||
### CSS | ||
De CSS heb ik gelinkt in de `<head>` | ||
|
||
Ik heb de veel voorkomende styles genoteerd in de `root`, zodat ik dit overal makkelijk kan gebruiken | ||
```css | ||
:root { | ||
--mainFont: 'Proxima Nova', sans-serif; | ||
--mainHeaderFontWeight: 600; | ||
--mainFontWeight: 400; | ||
--secondFontWeight: 350; | ||
--thirdFontWeight: 300; | ||
--mainFontSize: 20px; | ||
--secondFontSize: 16px; | ||
|
||
--mainColor: #F7A100; | ||
--mainFontColor: #333333; | ||
--secondFontColor: #999999; | ||
--thirdFontColor: #0071B3; | ||
--hoverOrangeColor: #de9000; | ||
|
||
--borderLight: #ededed; | ||
--borderDark: #CCCCCC; | ||
} | ||
``` | ||
|
||
### Responsive | ||
Om te zorgen dat de website goed functioneert op meerdere devices heb ik gebruikt gemaakt van `@media only screen and (min-width: ...px)` | ||
|
||
## Checklist pagina | ||
|
||
- [x] Buurt blokje | ||
- [x] Kaart blokje | ||
- [x] Reis blokje | ||
- [x] Responsive nav-bar | ||
- [x] Responsive footer | ||
- [x] Responsive sections | ||
- [x] Responsive main-image | ||
- [x] Kenmerken tabel | ||
- [ ] Kenmerken tabel op mobiel in/uit klappen | ||
- [x] Belangrijkste kenmerken | ||
- [x] Uitklapbare beschrijving | ||
- [x] Ing sectie | ||
- [x] Vergelijkbaar in de buurt sectie | ||
- [x] Sidebar | ||
- [ ] Menu subitems | ||
- [ ] Mobiele dropdown |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mooi om te zien hoe georganiseerd je te werk bent gegaan. Je hebt zowel gebruik gemaakt van deze checklist als hele nette commits geschreven met duidelijk beschreven commit messages.