Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funda project | pull request | Larissa Mikkers #21

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
995e9e4
nav toegevoegd
Lmikkers Jan 22, 2024
c7b3eb7
nav aangepast + content erbij
Lmikkers Jan 22, 2024
a34af80
nav aangepast style + html
Lmikkers Jan 22, 2024
f33a88f
div naar ul li menu
Lmikkers Jan 22, 2024
294538b
nav aangepast
Lmikkers Jan 22, 2024
6e36ba2
header images grid template
Lmikkers Jan 22, 2024
19c943d
content aangepast
Lmikkers Jan 22, 2024
160a538
tabel opmaak
Lmikkers Jan 23, 2024
8f7df44
icons toegevoegd + tabel gefixt + lees meer
Lmikkers Jan 23, 2024
ab1af37
readmore
Lmikkers Jan 23, 2024
79c4d4d
Update index.html
Lmikkers Jan 23, 2024
907fa99
Update index.html
Lmikkers Jan 23, 2024
2464b73
Update index.html
Lmikkers Jan 23, 2024
6fd8e83
image slider aangepast
Lmikkers Jan 23, 2024
3a3deac
ing stukje erbij en woning waarde
Lmikkers Jan 23, 2024
82a5ca2
huis waarden + content toegevoegd onder
Lmikkers Jan 23, 2024
e34208c
activity add
Lmikkers Jan 23, 2024
b05845c
buurt toegevoed + new label
Lmikkers Jan 23, 2024
6782025
buurt
Lmikkers Jan 23, 2024
d2d09e8
in de buurt html css
Lmikkers Jan 23, 2024
3d9c084
map toegevoegd
Lmikkers Jan 23, 2024
bc25711
reistijd toegevoegd
Lmikkers Jan 23, 2024
509d4f5
vergelijkbaar buurt toegevoegd
Lmikkers Jan 23, 2024
0ef72e0
sidebar toegevoegd
Lmikkers Jan 24, 2024
7912e77
sidebar aangepast + container
Lmikkers Jan 24, 2024
5cc5b25
issues alt img opgelost
Lmikkers Jan 24, 2024
1259f3a
action even weggehaald form
Lmikkers Jan 24, 2024
43552b7
Footer toegevoegd + sidebar css
Lmikkers Jan 24, 2024
33eb23c
gridContainer margin aangepast
Lmikkers Jan 24, 2024
a91a3f3
Update style.css
Lmikkers Jan 24, 2024
00d0e51
!important toegevoegd container
Lmikkers Jan 24, 2024
0eb4e1e
pagina lijst einde aangepast responsive
Lmikkers Jan 24, 2024
f6e2156
sidebar gefixt
Lmikkers Jan 24, 2024
a3912ee
Update style.css
Lmikkers Jan 24, 2024
d7330a9
em naar rem
Lmikkers Jan 24, 2024
efa1aa3
html css netjes gemaakt
Lmikkers Jan 24, 2024
1424626
kleine aanpassingen + JS
Lmikkers Jan 25, 2024
ee4d72f
Update README.md
Lmikkers Jan 25, 2024
ee32570
Update README.md
Lmikkers Jan 25, 2024
5f07dab
Update README.md
Lmikkers Jan 25, 2024
0465820
Update README.md
Lmikkers Jan 25, 2024
3a237ac
Update README.md
Lmikkers Jan 25, 2024
2df12b1
Update README.md
Lmikkers Jan 25, 2024
f67af89
Update README.md
Lmikkers Jan 25, 2024
f01d4c0
Update README.md
Lmikkers Jan 25, 2024
2c226e4
Update README.md
Lmikkers Jan 25, 2024
83f587b
Update README.md
Lmikkers Jan 25, 2024
b2f0faf
Update README.md
Lmikkers Jan 25, 2024
561e6fa
Update README.md
Lmikkers Jan 25, 2024
b4c391a
Update README.md
Lmikkers Jan 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"liveServer.settings.port": 5501
}
82 changes: 78 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,80 @@
<img width="123" alt="image" src="https://github.com/fdnd-agency/funda/assets/1061632/971b90d8-5c19-46a1-a19c-5414aee155c3">
# Funda Design Challenge Sprint 6

# Projecten
<img src="https://github.com/Lmikkers/funda/assets/94455811/60f4b070-09ce-48e2-8338-ccde900e7967">
https://lmikkers.github.io/funda/

* Jaar 1: [Design Challenge Sprint 6](https://github.com/fdnd-agency/funda/blob/main/design-challenge-sprint-6/README.md)
* Jaar 2: [Favourite Houses](https://github.com/fdnd-agency/funda/blob/main/favourite-houses/README.md)

## Inhoudsopgave
- [Opdrachtgever](https://github.com/Lmikkers/funda/blob/main/README.md#opdrachtgever)
- [Gebruik website](https://github.com/Lmikkers/funda/blob/main/README.md#gebruik-van-website)
- [Kenmerken](https://github.com/Lmikkers/funda/blob/main/README.md#kenmerken)
- [Checklist](https://github.com/Lmikkers/funda/blob/main/README.md#checklist-pagina)

## Opdrachtgever
### Funda
Funda is een vastgoedplatform voor consumenten en ondernemers. Via Funda kun je huizen kopen, verkopen en huren.

Opdrachtomschrijving

> Het maken (nabouwen) van een detailpagina en verbeteren waar nodig is in hardcode vanille html, css en javascript. En ervoor zorgen dat de code mobile first wordt gebouwd.

## Gebruik van website
Je kunt de website op Telefoon, Tablet en desktop openen op deze link: https://lmikkers.github.io/funda/
[https://lmikkers.github.io/funda/](https://lmikkers.github.io/funda/)

## Kenmerken
- HTML
- CSS
- Responsive

### HTML
Structuur: `<header>` `<main>` `<footer>`

Onderverdeeld in: `<nav>` `<section>` `<article>` `<div>`

### CSS
De CSS heb ik gelinkt in de `<head>`

Ik heb de veel voorkomende styles genoteerd in de `root`, zodat ik dit overal makkelijk kan gebruiken
```css
:root {
--mainFont: 'Proxima Nova', sans-serif;
--mainHeaderFontWeight: 600;
--mainFontWeight: 400;
--secondFontWeight: 350;
--thirdFontWeight: 300;
--mainFontSize: 20px;
--secondFontSize: 16px;

--mainColor: #F7A100;
--mainFontColor: #333333;
--secondFontColor: #999999;
--thirdFontColor: #0071B3;
--hoverOrangeColor: #de9000;

--borderLight: #ededed;
--borderDark: #CCCCCC;
}
```

### Responsive
Om te zorgen dat de website goed functioneert op meerdere devices heb ik gebruikt gemaakt van `@media only screen and (min-width: ...px)`

## Checklist pagina

- [x] Buurt blokje
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mooi om te zien hoe georganiseerd je te werk bent gegaan. Je hebt zowel gebruik gemaakt van deze checklist als hele nette commits geschreven met duidelijk beschreven commit messages.

- [x] Kaart blokje
- [x] Reis blokje
- [x] Responsive nav-bar
- [x] Responsive footer
- [x] Responsive sections
- [x] Responsive main-image
- [x] Kenmerken tabel
- [ ] Kenmerken tabel op mobiel in/uit klappen
- [x] Belangrijkste kenmerken
- [x] Uitklapbare beschrijving
- [x] Ing sectie
- [x] Vergelijkbaar in de buurt sectie
- [x] Sidebar
- [ ] Menu subitems
- [ ] Mobiele dropdown
Binary file added assets/360Fotos.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/Kaart.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
69 changes: 69 additions & 0 deletions assets/Kaart.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions assets/Map.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/bmScreenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions assets/fundawonen-logo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/hoofdImage.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/icons/360.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/icons/Calendar.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/icons/Clock.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions assets/icons/Energy-label.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions assets/icons/ING.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions assets/icons/Map-illustration.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/icons/Phone.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions assets/icons/Thumbnail.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions assets/icons/alleMedia.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/icons/arrowDown.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/icons/arrowRight.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/icons/bed.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading