Update Python & Django supported versions + migrate to ruff #551
Conversation
samiashi
force-pushed
the
bump-python-django
branch
5 times, most recently
from
3568c99
to
3d189b6
Compare
samiashi
changed the title
samiashi
force-pushed
the
bump-python-django
branch
3 times, most recently
from
263fd12
to
8a20f52
Compare
| @@ -36,7 +37,7 @@ exclude = ["tests", "docs"] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.8" | |||
| django = ">=4.2,<5.0" | |||
| django = ">=4.2" | |||
There was a problem hiding this comment.
Further changes are needed in 5.1 of Django to maintain support - #534
| django = ">=4.2" | |
| django = ">=4.2,<5.1" |
There was a problem hiding this comment.
Hmm, if we do this, then people won't even bother installing the app beyond this version, nor will they be able to tolerate or fix minor issues in unsupported versions.
The decision to have an upper bound is contentious I admit, if this package is absolutely broken on Django 5.1 then maybe it's a good idea, but otherwise, maybe we should leave it open and endeavour to resolve issues as they arise
There was a problem hiding this comment.
Ah yeah good point. It's not totally broken in 5.1. This seems to only impact fieldsets, so likely still a widespread issue.
| @@ -42,7 +42,7 @@ def test_logout(admin_client): | |||
| """ | |||
| url = reverse("admin:logout") | |||
|
|
|||
| response = admin_client.get(url) | |||
| response = admin_client.post(url) | |||
There was a problem hiding this comment.
Interesting this wasn't already done, as I thought we fixed the logout issue already
There was a problem hiding this comment.
The logout via GET was deprecated in Django 4.1 hence why it wasn't caught earlier
https://docs.djangoproject.com/en/4.2/releases/4.1/#log-out-via-get
There was a problem hiding this comment.
Yeah, I think it might have been missed in #544
|
@farridav the 3.11 build is failing I'm not sure why it can't find the |
| @@ -36,7 +37,7 @@ exclude = ["tests", "docs"] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.8" | |||
| django = ">=4.2,<5.0" | |||
| django = ">=4.2" | |||
There was a problem hiding this comment.
Hmm, if we do this, then people won't even bother installing the app beyond this version, nor will they be able to tolerate or fix minor issues in unsupported versions.
The decision to have an upper bound is contentious I admit, if this package is absolutely broken on Django 5.1 then maybe it's a good idea, but otherwise, maybe we should leave it open and endeavour to resolve issues as they arise
|
Yeah it's odd, probably some sort of a permissions issue, I will see if I can make sense of it and get the coveralls token working properly |
samiashi
force-pushed
the
bump-python-django
branch
from
8a20f52
to
0f821fd
Compare
samiashi
force-pushed
the
bump-python-django
branch
from
0f821fd
to
e00b297
Compare
|
Right, lets get this moving.. a massive step in the right direction here .. Next steps will be to make the entire codebase properly typed, start making use of pydantic (or at least data classes) for configuration. And get some better test coverage :) |
Drop support for Django 2.2, 3.0 & 3.1 and add support for Django 4.2
samiashi
force-pushed
the
bump-python-django
branch
from
e00b297
to
700caf0
Compare
|
Can we get a reabase on this ? Then we can get it merged ... |
@farridav Should be rebased with master now |
Update Python supported versions - https://devguide.python.org/versions/
Update Django supported versions - https://www.djangoproject.com/download/#supported-versions
Migrate to ruff - https://github.com/astral-sh/ruff
Miscellaneous