-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(userspace/libsinsp): disable HTTP proxy for CRI connection #2113
fix(userspace/libsinsp): disable HTTP proxy for CRI connection #2113
Conversation
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Signed-off-by: Wiktor Gołgowski <[email protected]>
bc92c52
to
0f6c997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 4c895fcb8306238c373d3bebb1b9def1c1ce3151
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, wigol The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2113 +/- ##
=======================================
Coverage 73.69% 73.69%
=======================================
Files 253 253
Lines 31914 31916 +2
Branches 5613 5631 +18
=======================================
+ Hits 23519 23521 +2
- Misses 8371 8375 +4
+ Partials 24 20 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This change explicitly configures GRPC channel used for CRI socket communication to skip HTTP proxy configuration.
Since the CRI path already hardcodes
unix://
, the proxy will not be used anyway, but by disabling it we are silencing the unnecessary error message.See https://github.com/grpc/grpc/blob/2de2e8dd8921e1f7d043e01faf7fe8a291fbb072/src/core/ext/filters/client_channel/http_proxy.cc#L111 and https://github.com/grpc/grpc/blob/2de2e8dd8921e1f7d043e01faf7fe8a291fbb072/src/core/ext/filters/client_channel/http_proxy.cc#L122-L125 .
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: