Windows Build Support

[openmoverse]

This PR enabled the automated build support for windows using vcpkg, the libraries have beed added to the manifest file (vcpkg.json) located at the root directory. Installation guide is present in README.MD under Windows Installation.

CHANGES

vrs/utils/test/JxlTest.cpp
definition of M_PI, seems like header for windows does not have a proper definition of M_PI

---

vrs/oss/logging/Verify.h and vrs/oss/logging/Checks.h
fixed MACROS not working properly in windows mode, using a define guard.

---

vrs/CMakeLists.txt

• added link to static lib bcrypt . This solves a linking error, where some function definitions are not found (they should be present in boost, but there's an issue with boost and autolinking , issue).
• enabled /bigobj option, which is required for vrslib project in debug

CAVEATS

When building with unit tests, not all tests are able to build. More specifically in Release 1 test fails to build (to link) and in Debug 3 tests fail to build (link). In both Release and Debug modes, also 1 test fails to pass. Output of the tests are attached to this PR.
Other that that, vrs CLI and Player work properly and we're using it as an external library without any issues on our Windows machines.

vrs_tests_debug.txt
vrs_tests_release.txt

[facebook-github-bot]

Hi @openmoverse!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

@SeaOtocinclus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@openmoverse has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@openmoverse has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@openmoverse has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@openmoverse has updated the pull request. You must reimport the pull request before landing.

[georges-berenger]

@SeaOtocinclus the changes look good to me, but they already map to an internal diff of yours, with other things in there. Do you mind getting these changes in?

[facebook-github-bot]

@georges-berenger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.