TMA version of hstu #57
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
added
the
CLA Signed
|
@LinjianMa Any comment on where to put the TMA variant, in the same file or in a separate file? Is there a perf benchmark we can run? We may consider using TMA for output and q as well. |
plotfi
added a commit
to plotfi/generative-recommenders
that referenced
this pull request
Aug 21, 2024
Based on facebookresearch#57, this version uses the autotuned to toggle use of TMA.
plotfi
added a commit
to plotfi/generative-recommenders
that referenced
this pull request
Sep 4, 2024
Based on facebookresearch#57, this version uses the autotuned to toggle use of TMA.
plotfi
added a commit
to plotfi/generative-recommenders
that referenced
this pull request
Sep 4, 2024
Based on facebookresearch#57, this version uses the autotuned to toggle use of TMA.
plotfi
added a commit
to plotfi/generative-recommenders
that referenced
this pull request
Sep 4, 2024
Based on facebookresearch#57, this version uses the autotuned to toggle use of TMA.
plotfi
added a commit
to plotfi/generative-recommenders
that referenced
this pull request
Sep 4, 2024
Based on facebookresearch#57, this version uses the autotuned to toggle use of TMA.
plotfi
added a commit
to plotfi/generative-recommenders
that referenced
this pull request
Sep 4, 2024
Based on facebookresearch#57, this version uses the autotuned to toggle use of TMA.
plotfi
added a commit
to plotfi/generative-recommenders
that referenced
this pull request
Sep 7, 2024
Based on facebookresearch#57, this version uses the autotuned to toggle use of TMA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TMA version is added as a separate file, we have seen it improves perf in some cases and regresses perf in other cases. We are also working on improving TMA performance from Triton.