Add remove ids for indexrefine #4026
Conversation
add remove for refine
Update IndexRefine.h
|
Hi @Tickdack! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
faiss/IndexRefine.cpp
Outdated
| base_index->remove_ids(sel); | ||
| refine_index->remove_ids(sel); | ||
| ntotal = refine_index->ntotal; | ||
| return -1; |
There was a problem hiding this comment.
I believe the return value is supposed to be the number of vectors removed. You should be able to do this by getting the ntotal of the refine_index (or base_index - they should be the same) before applying the remove_ids operation.
Co-authored-by: gtwang01 <[email protected]>
|
@gtwang01 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Can you add some unit tests to ensure reliability? |
ok,i will add unit tests |
No description provided.