-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interop between CAGRA and HNSW #3252
Closed
Closed
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
753a109
start integration of cagra
divyegala 6ce2467
merge upstream
divyegala f21c1f1
add public API layer
divyegala 11c0c54
merge upstream
divyegala 656f493
write tests, figure out a way to compare
divyegala de67ca6
Merge remote-tracking branch 'upstream/main' into raft-cagra
divyegala ed32954
passing tests
divyegala 42ca862
remove cpp test file
divyegala 2fdfc6f
Merge remote-tracking branch 'upstream/main' into raft-cagra
divyegala 2c9e965
style check
divyegala 2e434fe
add required methods
divyegala 382c178
conditionally compile cagra
divyegala 8675974
copyTo and copyFrom
divyegala c7fcf4a
style check
divyegala eae832d
Merge branch 'main' into raft-cagra-hnsw
divyegala 4b76e5f
Merge branch 'main' into raft-cagra-hnsw
divyegala 065f912
add read/write
divyegala 301f429
Merge remote-tracking branch 'origin/raft-cagra-hnsw' into raft-cagra…
divyegala 2b0ea76
add destructor
divyegala 8c83bd2
destructor body, copyto reset
divyegala 39fb35a
remove destructor
divyegala 49e2610
move cmake sources around
divyegala 11bf6b2
merge upstream
divyegala d4434bb
more protections for copying
divyegala ac65c2d
support default constructed IndexHnswCagra in copyTo
divyegala 619c376
fix failing binary hnsw tests
divyegala e25f8a4
link faiss_gpu target to OpenMP
divyegala e835150
raft still can't find openmp
divyegala aeabe12
openmp flags and uint32 IndexType
divyegala 4e80586
forgot conditional check in index_read
divyegala c4bcaba
minor changes
divyegala 341a3fc
api change
divyegala 0ae7702
Merge branch 'raft-api-changes' into raft-cagra-hnsw
divyegala 172aa65
working python
divyegala 0cd684e
compile option to swig
divyegala 7ff8b3b
expose ivf pq params
divyegala 66d236f
update comments style
divyegala f697eac
Merge remote-tracking branch 'upstream/main' into raft-cagra-hnsw
divyegala 1d6e6b1
use raft::runtime where possible
divyegala 4a01ad4
format
divyegala 949e634
format properly
divyegala bccd54a
InnerProduct
divyegala 320654c
Merge remote-tracking branch 'upstream/main' into raft-cagra-hnsw
divyegala 2aaa6e9
passing ip tests
divyegala 70b0ab8
address review
divyegala e5756cc
Merge remote-tracking branch 'upstream/main' into raft-cagra-hnsw
divyegala 8f72ce4
Merge remote-tracking branch 'upstream/main' into raft-cagra-hnsw
divyegala 4148fea
base level only search
divyegala c13bcff
Merge remote-tracking branch 'upstream/main' into raft-cagra-hnsw
divyegala 24a555d
fix virtual functions and serialization
divyegala 51227b1
invert conditional
divyegala 579a301
debug msg
divyegala ae0b8ba
more debug prints
divyegala 4170a3e
fix efSearch setting in base search
divyegala 75808b1
re-negate ip distances in search_level
divyegala 09fb95b
Merge remote-tracking branch 'upstream/main' into raft-cagra-hnsw
divyegala 9bd1039
fix format
divyegala ea8028d
re-up minimum recall for base only IP distance
divyegala fc31351
add python tests
divyegala 3e2d343
Merge remote-tracking branch 'upstream/main' into raft-cagra-hnsw
divyegala 03ee1fb
ifdef guards in gpu cloner
divyegala 2e9cbc8
option to exclude dataset store on index
divyegala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we want to keep this as Faiss is not necessarily compiled in a conda env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry. This was just for development purposes - I will remove it.