Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to Remove Lower and Upper Bounds from Models #459

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Refactor to Remove Lower and Upper Bounds from Models #459

wants to merge 17 commits into from

Commits on Nov 16, 2024

  1. proposed changes to address the inducing point allocators issue

    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    9157d6d View commit details
    Browse the repository at this point in the history

  2. fix minor mypy error in inducing_point_allocators

    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    c902591 View commit details
    Browse the repository at this point in the history

  3. rebase it all with the newest main

    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    c2a1700 View commit details
    Browse the repository at this point in the history

  4. fix minor error caused by rebasing

    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    6fc3131 View commit details
    Browse the repository at this point in the history

  5. fixed minor proposed changes

    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    7d64015 View commit details
    Browse the repository at this point in the history

  6. imporve points allocators classes to work directly with configs and a… 

    …dd tests to check for its functionality
    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    6ce12ec View commit details
    Browse the repository at this point in the history

  7. imporve points allocators classes to work directly with configs and a… 

    …dd tests to check for its functionality
    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    1e8f30b View commit details
    Browse the repository at this point in the history

  8. rebasing with updates & initialized all points allocators with the ne… 

    …w ConfigurableMixin class
    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    9a7f26f View commit details
    Browse the repository at this point in the history

  9. reformat follwoing ufmt

    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    47cb53e View commit details
    Browse the repository at this point in the history

  10. fix gpu issue

    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    bc8b4da View commit details
    Browse the repository at this point in the history

  11. update from_config to use the new get_bounds function

    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    cf5a0c9 View commit details
    Browse the repository at this point in the history

  12. fix the formating in the changed files

    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    698d6ee View commit details
    Browse the repository at this point in the history

  13. update all models to work without lb and ub

    @yalsaffar
    yalsaffar committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    3052359 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. refactor models not to require lower and upper bounds

    @yalsaffar
    yalsaffar committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0482aaf View commit details
    Browse the repository at this point in the history

  2. update other objects to work with the new structure & migrate the met… 

    …hods from models/base to strategy
    @yalsaffar
    yalsaffar committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    15f395f View commit details
    Browse the repository at this point in the history

  3. update all test cases to work with the new structure

    @yalsaffar
    yalsaffar committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    87261b4 View commit details
    Browse the repository at this point in the history

  4. update formating in all modified files

    @yalsaffar
    yalsaffar committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f2eadbc View commit details
    Browse the repository at this point in the history