add support for binary parameters #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65954134 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 14, 2024
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Differential Revision: D65954134
JasonKChow
force-pushed
the
export-D65954134
branch
from
52ab256
to
bf2275a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65954134 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 14, 2024
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Differential Revision: D65954134
JasonKChow
force-pushed
the
export-D65954134
branch
from
bf2275a
to
61f04a2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65954134 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 14, 2024
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Differential Revision: D65954134
JasonKChow
force-pushed
the
export-D65954134
branch
from
61f04a2
to
6c0d957
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65954134 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 14, 2024
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Differential Revision: D65954134
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 14, 2024
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Differential Revision: D65954134
JasonKChow
force-pushed
the
export-D65954134
branch
from
6c0d957
to
8ed95b4
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 15, 2024
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Differential Revision: D65954134
|
This pull request was exported from Phabricator. Differential Revision: D65954134 |
JasonKChow
force-pushed
the
export-D65954134
branch
from
8ed95b4
to
034b1b7
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 15, 2024
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Differential Revision: D65954134
|
This pull request was exported from Phabricator. Differential Revision: D65954134 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 15, 2024
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Differential Revision: D65954134
JasonKChow
force-pushed
the
export-D65954134
branch
from
034b1b7
to
7127015
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65954134 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 19, 2024
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Reviewed By: crasanders Differential Revision: D65954134
JasonKChow
force-pushed
the
export-D65954134
branch
from
7127015
to
f69a76d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65954134 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 20, 2024
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Reviewed By: crasanders Differential Revision: D65954134
JasonKChow
force-pushed
the
export-D65954134
branch
from
f69a76d
to
d0675de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65954134 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 20, 2024
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Reviewed By: crasanders Differential Revision: D65954134
JasonKChow
force-pushed
the
export-D65954134
branch
from
d0675de
to
b82bfe5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65954134 |
Summary: Discrete parameter support added via rounding transform. Reviewed By: crasanders Differential Revision: D65699942
Summary: Transforming bounds requires additional logic that used to be part of ParameterTransforms, we move these to the parameters itself and have the ParameterTransforms look for these special methods when transforming bounds. We add a new ABC for our transforms as going forward it is likely that all of our transforms will have unique capabilities over the BoTorch base. This includes how we handle some finding options from configs. Reviewed By: crasanders Differential Revision: D65897908
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Reviewed By: crasanders Differential Revision: D65898366
… tensors (facebookresearch#455) Summary: This removes the numpy dependency from the manual generators and changes the logic slightly so that we can support higher dimensional tensors of points, allowing us to support pairwise experiments Reviewed By: crasanders Differential Revision: D64607853
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Reviewed By: crasanders Differential Revision: D65954134
JasonKChow
force-pushed
the
export-D65954134
branch
from
b82bfe5
to
22330c4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65954134 |
|
This pull request has been merged in 2ba8445. |
JasonKChow
added a commit
that referenced
this pull request
Nov 25, 2024
Summary: Pull Request resolved: #454 Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Reviewed By: crasanders Differential Revision: D65954134 fbshipit-source-id: 0afb0bd9639f26ccb965bbe7880ca5e6576a3b12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling.
Differential Revision: D65954134