add support for categorical parameters #449
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65779384 |
Summary: Discrete parameter support added via rounding transform. Reviewed By: crasanders Differential Revision: D65699942
Summary: Transforming bounds requires additional logic that used to be part of ParameterTransforms, we move these to the parameters itself and have the ParameterTransforms look for these special methods when transforming bounds. We add a new ABC for our transforms as going forward it is likely that all of our transforms will have unique capabilities over the BoTorch base. This includes how we handle some finding options from configs. Reviewed By: crasanders Differential Revision: D65897908
Summary: Added support for categorical parameters. This required changing some server functions to be able to take and give strings as a part of the responses. Externally, categorical parameters are strings. Internally, categorical parameters are represented as index parameters (0, nChoices -1) while they are passed to models as one_hot vectored parameters. The index intermediate could be useful in the future for alternative ways to model categorical parameters. Differential Revision: D65779384
JasonKChow
force-pushed
the
export-D65779384
branch
from
6cad20c
to
c24bbd9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65779384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added support for categorical parameters. This required changing some server functions to be able to take and give strings as a part of the responses.
Externally, categorical parameters are strings. Internally, categorical parameters are represented as index parameters (0, nChoices -1) while they are passed to models as one_hot vectored parameters. The index intermediate could be useful in the future for alternative ways to model categorical parameters.
Differential Revision: D65779384