fix numerical issues for lookahead_levelset_at_xstar #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59839473 |
|
This pull request was exported from Phabricator. Differential Revision: D59839473 |
wenx-guo
added a commit
to wenx-guo/aepsych
that referenced
this pull request
Aug 16, 2024
…h#370) Summary: Pull Request resolved: facebookresearch#370 The `lookahead_levelset_at_xstar` in `lookahead_utils,py` has several divisions where the denominator could be 0. For example, P1 = Z_qs / py1: py1=normal cdf(a star) could potentially be 0 when a_star is very negative number, causing division by 0 and P1 equals to nans. Reviewed By: crasanders Differential Revision: D59839473
wenx-guo
force-pushed
the
export-D59839473
branch
from
fd1a662
to
d4c9320
Compare
…h#370) Summary: Pull Request resolved: facebookresearch#370 The `lookahead_levelset_at_xstar` in `lookahead_utils,py` has several divisions where the denominator could be 0. For example, P1 = Z_qs / py1: py1=normal cdf(a star) could potentially be 0 when a_star is very negative number, causing division by 0 and P1 equals to nans. Reviewed By: crasanders Differential Revision: D59839473
|
This pull request was exported from Phabricator. Differential Revision: D59839473 |
wenx-guo
force-pushed
the
export-D59839473
branch
from
d4c9320
to
e277d5e
Compare
|
This pull request has been merged in 26405e3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
lookahead_levelset_at_xstarinlookahead_utils,pyhas several divisions where the denominator could be 0.For example, P1 = Z_qs / py1: py1=normal cdf(a star) could potentially be 0 when a_star is very negative number, causing division by 0 and P1 equals to nans.
Differential Revision: D59839473