Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add probit as the default link function in the BernoulliMI acquisition function #353

Closed
wants to merge 1 commit into from
Closed

add probit as the default link function in the BernoulliMI acquisition function #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion aepsych/acquisition/mutual_information.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import torch
from aepsych.acquisition.monotonic_rejection import MonotonicMCAcquisition
from aepsych.acquisition.objective import ProbitObjective
from botorch.acquisition.input_constructors import acqf_input_constructor
from botorch.acquisition.monte_carlo import MCAcquisitionFunction
from botorch.acquisition.objective import MCAcquisitionObjective
Expand Down Expand Up @@ -64,7 +65,7 @@ class BernoulliMCMutualInformation(MCAcquisitionFunction):
def __init__(
self,
model: Model,
objective: MCAcquisitionObjective,
objective: MCAcquisitionObjective = None,
sampler: Optional[MCSampler] = None,
) -> None:
r"""Single Bernoulli mutual information for active learning
Expand All @@ -77,6 +78,8 @@ def __init__(
"""
if sampler is None:
sampler = SobolQMCNormalSampler(sample_shape=torch.Size([1024]))
if objective is None:
objective = ProbitObjective()
super().__init__(
model=model, sampler=sampler, objective=objective, X_pending=None
)
Expand Down
Loading