Update run_indefinetly to directly inherit from TransitionCriterion #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52853023 |
mgarrard
force-pushed
the
export-D52853023
branch
from
b86a7e9
to
82a7174
Compare
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 18, 2024
…acebookresearch#329) Summary: We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff we update the 4 of 4 aepsych completion criterion to directly rely on transitioncriterion In following diffs we will: - Completely remove the completion criterion file - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true - determine if additional updates to min_asks and run_indefinetly are necessary Differential Revision: D52853023
|
This pull request was exported from Phabricator. Differential Revision: D52853023 |
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing Differential Revision: D52852317
…kresearch#328) Summary: We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff we update the 3rd of 4 aepsych completion criterion to directly rely on transitioncriterion In following diffs we will: - Completely remove the completion criterion file - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true - determine if additional updates to min_asks and run_indefinetly are necessary Differential Revision: D52852941
…acebookresearch#329) Summary: We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff we update the 4 of 4 aepsych completion criterion to directly rely on transitioncriterion In following diffs we will: - Completely remove the completion criterion file - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true - determine if additional updates to min_asks and run_indefinetly are necessary Differential Revision: D52853023
mgarrard
force-pushed
the
export-D52853023
branch
from
82a7174
to
32fcfe9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52853023 |
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 22, 2024
…acebookresearch#329) Summary: This diff we update the 4 of 4 aepsych completion criterion to directly rely on transitioncriterion In following diffs we will: - Completely remove the completion criterion file - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true - determine if additional updates to min_asks and run_indefinetly are necessary Differential Revision: D52853023
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 24, 2024
…acebookresearch#329) Summary: This diff we update the 4 of 4 aepsych completion criterion to directly rely on transitioncriterion In following diffs we will: - Completely remove the completion criterion file - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true - determine if additional updates to min_asks and run_indefinetly are necessary Reviewed By: crasanders Differential Revision: D52853023
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 26, 2024
…acebookresearch#329) Summary: This diff we update the 4 of 4 aepsych completion criterion to directly rely on transitioncriterion In following diffs we will: - Completely remove the completion criterion file - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true - determine if additional updates to min_asks and run_indefinetly are necessary Reviewed By: crasanders Differential Revision: D52853023
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 29, 2024
…acebookresearch#329) Summary: This diff we update the 4 of 4 aepsych completion criterion to directly rely on transitioncriterion In following diffs we will: - Completely remove the completion criterion file - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true - determine if additional updates to min_asks and run_indefinetly are necessary Reviewed By: crasanders Differential Revision: D52853023
|
This pull request has been merged in 22ea32d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff we update the 4 of 4 aepsych completion criterion to directly rely on transitioncriterion
In following diffs we will:
Differential Revision: D52853023