Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of MinimumTrialsInStatus in AEPsych #326

Closed
wants to merge 1 commit into from
Closed

Remove usage of MinimumTrialsInStatus in AEPsych #326

wants to merge 1 commit into from

Commits on Jan 17, 2024

  1. Remove usage of MinimumTrialsInStatus in AEPsych 

    Summary:
X-link: facebook/Ax#2134

We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion `MinTrials`. This diff is the first in a set of diffs intended to update the legacy usage of CompletionCriterion in AEPsych.

In following diffs we will:
- Completely remove the completion criterion file
- update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15
- revisit storage
- remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code
- update AEPsych GSs as needed
- determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true

Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing

Differential Revision: D52848140

fbshipit-source-id: 8a2afb518671521f58d39fa4e4578a29d2d5fa1b
    @mgarrard @facebook-github-bot
    mgarrard authored and facebook-github-bot committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    59d93f3 View commit details
    Browse the repository at this point in the history