WIP fix bug where variational GPs wouldn't use correct likelihoods; use botorch inducing point selection; use botorch default mean/covar; update botorch/ax versions #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48891019 |
crasanders
pushed a commit
to crasanders/aepsych
that referenced
this pull request
Dec 8, 2023
…se botorch inducing point selection; use botorch default mean/covar; update botorch/ax versions (facebookresearch#323) Summary: This ensures variational GPs will use correct likelihoods, and it moves some logic out of AEPsych and into botorch. Anecdotally, the botorch priors seem to produce better models, and since we are so resource-strapped on the AEPsych side, we should rely on botorch logic as much as possible. Differential Revision: D48891019
crasanders
force-pushed
the
export-D48891019
branch
from
ce1f9b9
to
90cf3a0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48891019 |
crasanders
pushed a commit
to crasanders/aepsych
that referenced
this pull request
Dec 8, 2023
…se botorch inducing point selection; use botorch default mean/covar; update botorch/ax versions (facebookresearch#323) Summary: This ensures variational GPs will use correct likelihoods, and it moves some logic out of AEPsych and into botorch. Anecdotally, the botorch priors seem to produce better models, and since we are so resource-strapped on the AEPsych side, we should rely on botorch logic as much as possible. Differential Revision: D48891019
crasanders
force-pushed
the
export-D48891019
branch
from
90cf3a0
to
7dc79d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48891019 |
crasanders
pushed a commit
to crasanders/aepsych
that referenced
this pull request
Dec 8, 2023
…se botorch inducing point selection; use botorch default mean/covar; update botorch/ax versions (facebookresearch#323) Summary: This ensures variational GPs will use correct likelihoods, and it moves some logic out of AEPsych and into botorch. Anecdotally, the botorch priors seem to produce better models, and since we are so resource-strapped on the AEPsych side, we should rely on botorch logic as much as possible. Differential Revision: D48891019
crasanders
force-pushed
the
export-D48891019
branch
from
7dc79d6
to
d729d28
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48891019 |
crasanders
force-pushed
the
export-D48891019
branch
from
d729d28
to
c77e206
Compare
crasanders
pushed a commit
to crasanders/aepsych
that referenced
this pull request
Dec 8, 2023
…se botorch inducing point selection; use botorch default mean/covar; update botorch/ax versions (facebookresearch#323) Summary: This ensures variational GPs will use correct likelihoods, and it moves some logic out of AEPsych and into botorch. Anecdotally, the botorch priors seem to produce better models, and since we are so resource-strapped on the AEPsych side, we should rely on botorch logic as much as possible. Differential Revision: D48891019
|
This pull request was exported from Phabricator. Differential Revision: D48891019 |
crasanders
pushed a commit
to crasanders/aepsych
that referenced
this pull request
Dec 8, 2023
…se botorch inducing point selection; use botorch default mean/covar; update botorch/ax versions (facebookresearch#323) Summary: This ensures variational GPs will use correct likelihoods, and it moves some logic out of AEPsych and into botorch. Anecdotally, the botorch priors seem to produce better models, and since we are so resource-strapped on the AEPsych side, we should rely on botorch logic as much as possible. Differential Revision: D48891019
crasanders
force-pushed
the
export-D48891019
branch
from
c77e206
to
78cb19d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48891019 |
crasanders
force-pushed
the
export-D48891019
branch
from
78cb19d
to
264938a
Compare
crasanders
added a commit
to crasanders/aepsych
that referenced
this pull request
Dec 13, 2023
…otorch inducing point selection; use botorch default mean/covar; update botorch/ax versions (facebookresearch#323) Summary: This ensures variational GPs will use correct likelihoods, and it moves some logic out of AEPsych and into botorch. Anecdotally, the botorch priors seem to produce better models, and since we are so resource-strapped on the AEPsych side, we should rely on botorch logic as much as possible. Differential Revision: D48891019
|
This pull request was exported from Phabricator. Differential Revision: D48891019 |
…otorch inducing point selection; use botorch default mean/covar; update botorch/ax versions (facebookresearch#323) Summary: This ensures variational GPs will use correct likelihoods, and it moves some logic out of AEPsych and into botorch. Anecdotally, the botorch priors seem to produce better models, and since we are so resource-strapped on the AEPsych side, we should rely on botorch logic as much as possible. Differential Revision: D48891019
crasanders
force-pushed
the
export-D48891019
branch
from
264938a
to
c81aee9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48891019 |
|
This pull request has been merged in 9e16a29. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This ensures variational GPs will use correct likelihoods, and it moves some logic out of AEPsych and into botorch. Anecdotally, the botorch priors seem to produce better models, and since we are so resource-strapped on the AEPsych side, we should rely on botorch logic as much as possible.
Differential Revision: D48891019