New Java LoggerFromOptions Logger implementation #13003
Open
+223
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhubner
reviewed
Sep 12, 2024
rhubner
reviewed
Sep 12, 2024
alanpaxton
force-pushed
the
eb/missing-create-logger-from-options
branch
2 times, most recently
from
c3d8c34
to
d6ca2f7
Compare
alanpaxton
force-pushed
the
eb/missing-create-logger-from-options
branch
from
d6ca2f7
to
f014680
Compare
The LoggerFromOptions class is a Logger implementation which allows the placement of the logger outside the DB. Used as a logger for a ReadOnly DB on a readonly filesystem, for instance. This is the Java manifestation of CreateLoggerFromOptions - created from a DBOptions.
- Use a static method CreateLoggerFromOptions to wrap the now private LoggerFromOptionsconstructor - Class comment - change names of internal methods for readability
Use standard macro for returning C++ pointer as Java JNIEXPORT and JNICALL not necessary in the implementation part of JNI methods, just the (autogenerated) declarations
alanpaxton
force-pushed
the
eb/missing-create-logger-from-options
branch
from
f9db2de
to
e3e4609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LoggerFromOptions class is a Logger implementation which allows the placement of the logger outside the DB. Used as a logger for a ReadOnly DB on a readonly filesystem, for instance.
This is the Java manifestation of CreateLoggerFromOptions - created from a DBOptions.