IngestExternalFileOptions update Java API to include several recently added option, in parity with C++ #12999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpaxton
force-pushed
the
eb/missing-options-file-ingest
branch
3 times, most recently
from
f6c2578
to
9ffac54
Compare
rhubner
reviewed
Sep 12, 2024
| * Method: verifyChecksumsBeforeIngest | ||
| * Signature: (J)Z | ||
| */ | ||
| JNIEXPORT jboolean JNICALL |
There was a problem hiding this comment.
Can we remove JNIEXPORT and JNICALL
rhubner
reviewed
Sep 12, 2024
alanpaxton
force-pushed
the
eb/missing-options-file-ingest
branch
2 times, most recently
from
5447c92
to
2b8c3e7
Compare
alanpaxton
force-pushed
the
eb/missing-options-file-ingest
branch
from
2b8c3e7
to
04fe12a
Compare
The C++ API IngestExternalFileOptions has options that are not present in the Java API. We have added these: verify_checksums_before_ingest verify_checksums_readahead_size verify_file_checksum fail_if_not_bottommost_level
New option literally appeared when I rebased to PR previous updates. Add linkFiles option now.
Convert true/false to JNI_TRUE/JNI_FALSE correctly
alanpaxton
force-pushed
the
eb/missing-options-file-ingest
branch
from
04fe12a
to
aaf8f82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ API IngestExternalFileOptions has options that are not present in the Java API. We have added Java version of these C++ options:
verify_checksums_before_ingest
verify_checksums_readahead_size
verify_file_checksum
fail_if_not_bottommost_level
link_files
The Java options are named in camelCase per Java standards.
The fail_if_not_bottommost_level has been named
failIfNotLastLevelper the discussion in the code comments.