Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android compilation #12914

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

kasperisager
Copy link
Contributor

I was seeing errors like these prior to this patch:

env/io_posix.cc:174:17: error: variable has incomplete type 'struct statfs'
  struct statfs buf;
env/io_posix.h:40:9: error: 'POSIX_MADV_NORMAL' macro redefined [-Werror,-Wmacro-redefined]
#define POSIX_MADV_NORMAL 0     /* [MC1] no further special treatment */

@kasperisager
Copy link
Contributor Author

I'm still seeing the following error for 32-bit builds:

env/io_posix.cc:1380:39: error: comparison of integers of different signs: 'long long' and 'unsigned long long' [-Werror,-Wsign-compare]
  file_stats.st_blksize !=

@kasperisager
Copy link
Contributor Author

@facebook-github-bot
Copy link
Contributor

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants