Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ImageRequestParams #47723

Closed
wants to merge 2 commits into from
Closed

Introduce ImageRequestParams #47723

wants to merge 2 commits into from

Commits on Nov 26, 2024

  1. [skip ci] Introduce Android ImageManger (facebook#47721) 

    Summary:

This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS.
Changelog: [Internal]

Differential Revision: D65753319
    @dmytrorykun @facebook-github-bot
    dmytrorykun authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7b0e384 View commit details
    Browse the repository at this point in the history

  2. Introduce ImageRequestParams (facebook#47723) 

    Summary:

Identity of `ImageRequest` is based on `ImageSource` and a subset of `ImageProps`. If any of those change, the request must be recreated and resubmitted.

Currently, the relevant subset of ImageProps is represented by a single `blurRadius` prop. This list will grow in the future. In order to simplify adding new props to the image request, we introduce the `ImageRequestParams` type that will wrap all the relevant props.

The alternative approach to pass `ImageProps` directly to `ImageManager` is worse because it would introduce dependency cycle between `ImageManager` and the `Image` component, and also it would require to store the props in State, which is bad.

Changelog: [Internal]

Differential Revision: D66172570
    @dmytrorykun @facebook-github-bot
    dmytrorykun authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    81965cf View commit details
    Browse the repository at this point in the history