Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespacing in Doc Blocks #551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix namespacing in Doc Blocks #551

wants to merge 1 commit into from

Conversation

garhbod
Copy link

@garhbod garhbod commented Mar 2, 2022

No description provided.

@facebook-github-bot
Copy link

Hi @garhbod!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@jeremyfrench
Copy link

This was signed over a year ago. I either have to use this to patch the download or put a bunch of exceptions in my code for it to not give me stan errors. It seems a trivial thing to merge.

@garhbod
Copy link
Author

garhbod commented Jun 18, 2023

Yeah I thought it would have been accepted straight away as it doesn't really change the code. Just fixes the issue

@mohlerit
Copy link

I have the same issue. Namespace are wrong and phpstan show it as error. Can someone finally merge it, please? :-)

Thank you ;-)

@geoffreyrose
Copy link
Contributor

fixed in #606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants