docs: list current Committers + bjohansebas nomination #6033
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
blakeembrey
requested changes
Oct 8, 2024
Signed-off-by: Ulises Gascon <[email protected]>
UlisesGascon
force-pushed
the
list-commiters
branch
from
21a2782
to
930f499
Compare
UlisesGascon
requested review from
blakeembrey,
a team,
carpasse and
bjohansebas
bjohansebas
approved these changes
Oct 20, 2024
|
ping |
UlisesGascon
added
tc agenda
top priority
|
I plan to land this on our next TC Meeting ;) |
blakeembrey
approved these changes
Nov 17, 2024
Co-authored-by: Blake Embrey <[email protected]>
jonchurch
approved these changes
Nov 20, 2024
wesleytodd
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
I left a comment in another one like this mentioning we need to move this out of the express repo. It is commit noise in here, and I would like to see us even automate this in the future with a membership list updater action.
All that said, since it is in here now I am alright going forward with this until we have a better solution. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR list current Committers for projects.
Note: I am +1 in the nomination, he have done non-trivial contributions in the project for a while. Note that I am repo captain for compression too (#6027)
cc: @expressjs/express-tc