Add Optional Timezone to now() #635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for an optional timezone argument to now(). Formatting the returned time will use the specified timezone.
Closed
antonmedv
requested changes
Apr 26, 2024
go.mod
Outdated
| @@ -2,7 +2,10 @@ module github.com/expr-lang/expr | |||
|
|
|||
| go 1.18 | |||
|
|
|||
| require github.com/stretchr/testify v1.8.4 | |||
| require ( | |||
| github.com/agiledragon/gomonkey/v2 v2.11.0 | |||
There was a problem hiding this comment.
Let's not add additional dependencies.
There was a problem hiding this comment.
It's just a test dependency to address the race in the tests. Any other preferred method for avoiding the race condition, or just leave it?
There was a problem hiding this comment.
It is a security concern. I'm also will be happy to avoid testify if possible. I understand what this is test dep, but apparently vet tools not: #618
Remove dependency on gomonkey in tests. Allow race condition in which clock may tick to the next minute between time.Now() calls.
|
I've implemented default timezone and program, err := expr.Compile(`now().Location().String()`, expr.Timezone("Asia/Kamchatka"))
if err != nil {
fmt.Printf("%v", err)
return
}
output, err := expr.Run(program, nil)
if err != nil {
fmt.Printf("%v", err)
return
}
fmt.Printf("%v", output)
// Output: Asia/Kamchatka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for an optional timezone argument to now(). Formatting the returned time will use the specified timezone.