feat: Operator overload from Function #408
Conversation
expr.go
Outdated
| @@ -127,6 +127,10 @@ func Function(name string, fn func(params ...interface{}) (interface{}, error), | |||
| Func: fn, | |||
| Types: ts, | |||
| } | |||
| c.Types[name] = conf.Tag{ | |||
There was a problem hiding this comment.
@antonmedv You said that functions can come from two places: TypesTable and Function.
So here I made the wrong decision, putting delegate from Function to the TypesTable? Instead, I should use config.Functions map in the config.Check function, and where we are searching for suitable operator overload, right?
nikolaymatrosov
force-pushed
the
feature/operator-overload-from-function
branch
from
71e88c2
to
7094458
Compare
|
I have entirely rewritten the PR. I do not no more mix Unfortunately, I can not figure out how to make work Function with the same name as Type but a different signature. I still don't know if it is a valid scenario, so I pushed my solution, missing this piece. |
|
|
||
| } | ||
|
|
||
| func TestOperator_FunctionOverTypesPrecedence(t *testing.T) { |
There was a problem hiding this comment.
As you suggested I also added test on precedence order.
|
Ok, looks good. Please rebase. |
|
In recent versions, this issue does not seem to have been solved, and it is very important for rewriting operations with functions |
|
Will take a look. |
nikolaymatrosov
force-pushed
the
feature/operator-overload-from-function
branch
from
4b677b2
to
d9b833c
Compare
|
I have rebased on the latest master. |
Closes #362