[ENG-9955][eas-build-job] add build phase to external build error #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-9955 Link to build logs from EAS CLI when build fails for unknown reason
In #1699 we added a link to the Xcode/Gradle build phase in EAS CLI when a build fails, and this was great. We should do a similar thing and remind people where the logs are when builds fail for other reasons. For example, a user asked about this on Discord: It may have been unclear to them what logs to refer to. The logs in the terminal? Do they even know other logs exist yet? Maybe not ;) They ended up finding this in the logs: So, ideally we would link to the logs page and with an anchor to the failing build phase. |
radoslawkrzemien
approved these changes
Aug 31, 2023
| constructor(buildPhase?: BuildPhase) { | ||
| super( | ||
| ErrorCode.UNKNOWN_ERROR, | ||
| buildPhase |
There was a problem hiding this comment.
Maybe also check if the buildPhase is in the keys of buildPhaseDisplayName, just to cover the case when buildPhase is set but the mapping is missing
szdziedzic
deleted the
@szdziedzic/add-build-phase-to-external-build-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://linear.app/expo/issue/ENG-9955/link-to-build-logs-from-eas-cli-when-build-fails-for-unknown-reason
How
Add information about the build phase to the
ExternalBuildErrorinterface. Add mappings from build phase enum to build phase display names and ids so they can be shared between multiple repos usingeas-build-jobpackageTest Plan
Tests