Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp/matrix] Basic csharp mentoring notes for the matrix problem #2213

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michalporeba
Copy link
Contributor

The problem can be solve in a number of ways, and it is good to have the examples ready to guide the students.
The alternative solution with multidimensional tables gets unnecessarily complex quickly so is not included.

The problem can be solve in a number of ways, and it is good to have the examples ready to guide the students. 
The alternative solution with multidimensional tables gets unnecessarily complex quickly so is not included.
@github-actions github-actions bot added track/csharp C# track type/mentor-notes Mentor notes labels Aug 13, 2022
It is based on the discussion from PR exercism#2212
@michalporeba
Copy link
Contributor Author

Hello, how can I help with reviews? Clearly there is problem with the flow. Is there somebody I could talk to perhaps about contributing to the content in C# track?

@IsaacG
Copy link
Member

IsaacG commented Mar 20, 2023

Hello, how can I help with reviews? Clearly there is problem with the flow. Is there somebody I could talk to perhaps about contributing to the content in C# track?

The Exercism forums is the place to discuss topics such as these.

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exercism/csharp can you quickly check so we can get this merged?

Comment on lines +3 to +4
Solution without Linq:
```csharp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Solution without Linq:
```csharp
Solution without Linq:
```csharp

Comment on lines +38 to +39
Solution with Linq:
```csharp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Solution with Linq:
```csharp
Solution with Linq:
```csharp

Comment on lines +63 to +64
### Common suggestions:
*Good suggestions specific to this exercise. Good lessons that emerge from it.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Common suggestions:
*Good suggestions specific to this exercise. Good lessons that emerge from it.*
### Common suggestions

Comment on lines +69 to +72
### Talking points:
*Questions to challenge more advance learners with.*

- The differences between multidimensional and jagged arrays in general and in C#.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Talking points:
*Questions to challenge more advance learners with.*
- The differences between multidimensional and jagged arrays in general and in C#.
### Talking points
- The differences between multidimensional and jagged arrays in general and in C#.

Comment on lines +73 to +79
In this case the data is dense so there are no memory efficiencies to talk about.
However, the choice influeces the type of code we can write.
- There are two problems: parsing of input and responding to queries.
Both are relatively simple and there is no need for input checking.
- The problem can be solved with iteration using loops and using Linq. What's the difference?
Both the parsing and access to column data change.
The change in parsing is more obvious between very imperative use of two loops vs more declarative expression using linq.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this case the data is dense so there are no memory efficiencies to talk about.
However, the choice influeces the type of code we can write.
- There are two problems: parsing of input and responding to queries.
Both are relatively simple and there is no need for input checking.
- The problem can be solved with iteration using loops and using Linq. What's the difference?
Both the parsing and access to column data change.
The change in parsing is more obvious between very imperative use of two loops vs more declarative expression using linq.
In this case the data is dense so there are no memory efficiencies to talk about.
However, the choice influences the type of code we can write.
- There are two problems: parsing of input and responding to queries.
Both are relatively simple and there is no need for input checking.
- The problem can be solved with iteration using loops and using Linq.
What's the difference?
Both the parsing and access to column data change.
The change in parsing is more obvious between very imperative use of two loops vs more declarative expression using Linq.

@SleeplessByte SleeplessByte changed the title Basic csharp mentoring notes for the matrix problem [csharp/matrix] Basic csharp mentoring notes for the matrix problem Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants