Merge pull request #82 from exercism/jie-unique-comments

Remove duplicate comments
exercism · Nov 28, 2023 · 43fb354 · 43fb354
2 parents f677f24 + 52c5e49
commit 43fb354
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/Comment.elm b/src/Comment.elm
@@ -75,7 +75,9 @@ aggregateComments : List Comment -> Summary
 aggregateComments comments =
     let
         sortedComments =
-            List.sortBy commentTypeShowOrder comments
+            comments
+                |> List.Extra.unique
+                |> List.sortBy commentTypeShowOrder
 
         ( message, extraComments ) =
             case List.map .commentType comments |> List.Extra.minimumBy commentTypeSummaryOrder of

diff --git a/tests/CommentTest.elm b/tests/CommentTest.elm
@@ -120,9 +120,9 @@ aggregateCommentsTest =
         , test "order of comments in summary is fixed" <|
             \() ->
                 Expect.equal
-                    (Comment.aggregateComments [ essential, informative, celebratory, actionable, informative ])
+                    (Comment.aggregateComments [ essential, informative, celebratory, actionable ])
                     (Summary "Check the comments for things to fix.\u{202F}🛠 "
-                        [ celebratory, essential, actionable, informative, informative, Comment.feedbackComment ]
+                        [ celebratory, essential, actionable, informative, Comment.feedbackComment ]
                     )
         , test "secondary order is alphabetical, but feedback is always last" <|
             \() ->
@@ -148,6 +148,13 @@ aggregateCommentsTest =
                         , Comment.feedbackComment
                         ]
                     )
+        , test "duplicate comments are removed" <|
+            \() ->
+                Expect.equal
+                    (Comment.aggregateComments [ essential, essential, celebratory, celebratory ])
+                    (Summary "Check the comments for things to fix.\u{202F}🛠 "
+                        [ celebratory, essential, Comment.feedbackComment ]
+                    )
         ]