-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Exercises directive & Added Chinese translation (zh_CN) #90
base: main
Are you sure you want to change the base?
Conversation
This is my first time to contribute. I am not familiar with the procedure at first. Now I get it. If there's more additional directives, please keep me posted to add corresponding Chinese translation. Thank you so much! |
Codecov ReportBase: 96.13% // Head: 96.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 96.13% 96.17% +0.04%
==========================================
Files 6 6
Lines 362 366 +4
==========================================
+ Hits 348 352 +4
Misses 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
thanks @11Haoyu -- you've done well for a first contribution. Thank you! I will review this over the next couple of days and get this merged. |
@11Haoyu we actually have another extension sphinx-exercise that has support for Maybe you can check that out to see if it meets your needs for exercise styling. |
Yes, I am aware of the extension of sphinx-exercise. But it seems that sphinx-exercise doesn't have translation function like sphinx-proof. Therefore, I added the exercise directive in sphinx-proof so people can use it in their own language. I would be so grateful if you can add translation in the sphinx-exercise as well, which is a very challenging task for me to write one from scratch. |
I see thanks @11Haoyu that makes sense. |
I will need to think a bit about the |
Yes, I understand that. |
to modify formats
Co-authored-by: Ming Yang [email protected]