Fixing tests

example42 · Sep 25, 2024 · 86ac0b1 · 86ac0b1
1 parent cee2146
commit 86ac0b1
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 14 deletions.
diff --git a/manifests/info.pp b/manifests/info.pp
@@ -25,7 +25,7 @@
   require puppi
   require puppi::params
 
-  if Array($run) {
+  if $run.type == Array {
     $array_run = $run
   } else {
     $array_run = $run ? {

diff --git a/manifests/install_packages.pp b/manifests/install_packages.pp
@@ -47,7 +47,7 @@
 define puppi::install_packages (
   String $packages,
   String $template         = 'puppi/install_packages.erb',
-  Srring $scripts_dir      = '/root/puppi_install_packages',
+  String $scripts_dir      = '/root/puppi_install_packages',
   Boolean $autorun          = true,
   Boolean $refreshonly      = true,
   Variant[String,Integer] $timeout          = '600',

diff --git a/manifests/log.pp b/manifests/log.pp
@@ -18,7 +18,7 @@
   require puppi
   require puppi::params
 
-  if Array($log) {
+  if $log.type == Array {
     $array_log = $log
   } else {
     $array_log = split($log, ',')

diff --git a/manifests/todo.pp b/manifests/todo.pp
@@ -36,7 +36,7 @@
   require puppi
   require puppi::params
 
-  if Array($run) {
+  if $run.type == Array {
     $array_run = $run
   } else {
     $array_run = $run ? {

diff --git a/spec/defines/configure_spec.rb b/spec/defines/configure_spec.rb
@@ -10,9 +10,12 @@
       let(:title) { 'namevar' }
       let(:node) { 'rspec.example42.com' }
       let(:pre_condition) { 'include puppi' }
-      let(:params) do
-        {}
-      end
+      let(:params) {
+        { 
+          'command' => 'test',
+          'project' => 'zip',
+        }
+      }
       it { is_expected.to compile }
     end
   end

diff --git a/spec/defines/netinstall_spec.rb b/spec/defines/netinstall_spec.rb
@@ -9,9 +9,12 @@
       let(:title) { 'namevar' }
       let(:node) { 'rspec.example42.com' }
       let(:pre_condition) { 'include puppi' }
-      let(:params) do
-        {}
-      end
+      let(:params) {
+        { 
+          'url'             => 'test',
+          'destination_url' => '/tmp',
+        }
+      }
       it { is_expected.to compile }
     end
   end

diff --git a/spec/defines/project_spec.rb b/spec/defines/project_spec.rb
@@ -10,11 +10,9 @@
       let(:node) { 'rspec.example42.com' }
       let(:pre_condition) { 'include puppi' }
       let(:params) {
-        { 'enable'   =>  'true',
+        {
+          'enable'   =>  'true',
           'name'     =>  'get',
-          'command'  =>  'echo',
-          'priority' =>  '50',
-          'project'  =>  'myapp',
         }
       }