Waveshare_3 correct position on the screen #39
Conversation
| @@ -39,7 +39,7 @@ def on_ui_setup(self, ui): | |||
| memenable = True | |||
| logging.info( | |||
| "Pwnagotchi Clock Plugin: memtemp is enabled") | |||
| if ui.is_waveshare_v2(): | |||
| if ui.is_waveshare_v2() or ui.is_waveshare_v3(): | |||
| pos = (130, 80) if memenable else (200, 80) | |||
There was a problem hiding this comment.
| pos = (130, 80) if memenable else (200, 80) | |
| pos = (110, 80) if memenable else (200, 80) |
You will also need to change this to 110 otherwise if memtemp is enabled it will obscure the clock trough i can't say what change this will bring to users of waveshare v2 because presumatly this worked fine on said versions so maybe it would make more sense to add another check for v2/v3 to differentiate between those two values
|
No point commenting. This entire repo has been abandoned |
you are probably right trough i figured even if this doesn't help much if someone else looks for a fix for said issue and they come across this PR i might as well document some small changes for them that are also needed (or for myself when i inevadably forget about it and then look the same PR up again) |
|
Yeah fair enough. Was just a heads up anyway |
No description provided.