Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle limits if it is not a category in a subpage #655

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

risjai
Copy link

@risjai risjai commented Oct 30, 2024

Remove any default limits for categories if its displayed on any other page where parent is present.
Bug : #630

screen-recording-2024-10-30-at-30535-pm_lAevZzT9.mp4

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@risjai risjai changed the title Remove any default limits for categories Handle limits if it is not a category in a subpage Oct 30, 2024
@treoden
Copy link
Collaborator

treoden commented Oct 31, 2024

Hi @risjai ,

It is not about root category listing, if you click on each category we need to make sure the sub categories are rendered full and correct

@risjai
Copy link
Author

risjai commented Oct 31, 2024

Hi @risjai ,

It is not about root category listing, if you click on each category we need to make sure the sub categories are rendered full and correct

@treoden Yup! I have tested that as well. That also works. You can try applying the patch.

@risjai
Copy link
Author

risjai commented Nov 4, 2024

Hi @risjai ,
It is not about root category listing, if you click on each category we need to make sure the sub categories are rendered full and correct

@treoden Yup! I have tested that as well. That also works. You can try applying the patch.

@treoden do you see any problems here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants