Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update :make-pqp-model for directly using glvertices #270

Merged
merged 1 commit into from
Oct 1, 2015

Conversation

YoheiKakiuchi
Copy link
Member

I updated make-pqp-model method to use glvertices directly, because converting glvertices to faces and making pqpmodel from them is very slow.

@snozawa
Copy link
Contributor

snozawa commented Sep 17, 2015

How about glvertices-related discussion?
jsk-ros-pkg/jsk_model_tools#41
jsk-ros-pkg/jsk_model_tools#125

@snozawa
Copy link
Contributor

snozawa commented Sep 17, 2015

I'd like to resolve these discussions about glvertices, but how about defining these functionality in collada-body's :make-pqpmodel method?

@YoheiKakiuchi
Copy link
Member Author

I think link should have :pqp-model property.
How to use pqpmodel in bodies from self-collision-check method ?

@snozawa
Copy link
Contributor

snozawa commented Sep 17, 2015

I think we need to refine glvertices methods in general,
but for hotfix, I'd like to find the way to define glvertices something in subclass.

pqp.l defines make-pqpmodel as cascaded-coords methods.
glvertices is subclass feature.
So, it is curious to add glvertices something to :make-pqpmodel method in pqp.l.

@YoheiKakiuchi
Copy link
Member Author

move make-pqpmodel method to glvertices

YoheiKakiuchi added a commit that referenced this pull request Oct 1, 2015
update :make-pqp-model for directly using glvertices
@YoheiKakiuchi YoheiKakiuchi merged commit 4930392 into euslisp:master Oct 1, 2015
@YoheiKakiuchi YoheiKakiuchi deleted the pqp_glvertices branch October 1, 2015 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants