Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Add --sim.buildarg flag #1179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

all: Add --sim.buildarg flag #1179

wants to merge 1 commit into from

Conversation

marioevz
Copy link
Member

Adds --sim.buildarg as a parameter to add build arguments to the simulator Dockerfile.

@marioevz
Copy link
Member Author

@spencer-tb @danceratopz

@danceratopz
Copy link
Member

@KolbyML @ScottyPoi This change will allow us to specify the "test fixture" release version used in the ethereum/execution-spec-test simulators on the command-line, just as we already specify the client version under test. Just wanted to share: perhaps it's useful for the Portal simulators?

@KolbyML
Copy link
Member

KolbyML commented Nov 19, 2024

This change will allow us to specify the "test fixture" release version used in the ethereum/execution-spec-test simulators on the command-line, just as we already specify the client version under test. Just wanted to share: perhaps it's useful for the Portal simulators?

I would find this ability useful, since I want/plan to be able to sub in testnet test data for our portal simulators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants