-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simulators/ethereum: add eest-engine/block-rlp for pectra devnet-3 #1162
base: master
Are you sure you want to change the base?
Conversation
@@ -359,7 +359,7 @@ function formatTestDetails(suiteData, row) { | |||
|
|||
if (d.description != '') { | |||
let p = document.createElement('p'); | |||
let description = html.urlsToLinks(html.encode(d.description.trim())); | |||
let description = html.urlsToLinks(d.description.trim()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor hiveview tweak as mentioned in the PR description.
@@ -58,5 +58,6 @@ def to_bool: | |||
"cancunTime": env.HIVE_CANCUN_TIMESTAMP|to_int, | |||
"pragueTime": env.HIVE_PRAGUE_TIMESTAMP|to_int, | |||
"terminalTotalDifficultyPassed": true, | |||
"depositContractAddress": "0x00000000219ab540356cBB839Cbe05303d7705Fa", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required for geth.
@@ -134,7 +134,7 @@ FLAGS="$FLAGS --ws --ws.port=8546" | |||
FLAGS="$FLAGS --txpool.blobslots=1000 --txpool.totalblobpoollimit=10000" | |||
|
|||
# Disable performance optimization incompatible with the tests | |||
FLAGS="$FLAGS --sync.parallel-state-flushing=false" | |||
# FLAGS="$FLAGS --sync.parallel-state-flushing=false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required for current erigon pectra branch. Can be added back in the future once updated in erigon.
Converting to draft until Please use https://hiveprague.ethdevops.io/ for client status's. |
Description
Adds
consume engine
andconsume rlp
from EEST as hive simulators:consume rlp
: equivalent to the./hive --sim ethereum/consensus
simulator. Executes blocks against clients via rlp.consume engine
: equivalent to the./hive --sim ethereum/pyspec
simulator. Executes blocks as engine new payloads via the engine api.These aim to deprecate both the pyspec and the consensus simulator in the near future.
Removes the
config/cancun.yaml
file in favor of aconfig/develop.yaml
file. These contain all the EL client configs for pectra devnet-3.Tweaks hiveview to remove some html encoding. Allow for code snippets provided by this PR from EEST. The end result gives us reproduce-able commands within hiveview for consume based simulators: