Fixes encrypt(), decrypt() and messages encode_defunct() doctests #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up for comments to PR ethereum#49, closes ethereum#81.
pipermerriam
approved these changes
Jan 20, 2020
|
Thank you very much for this cleanup. |
pacrob
pushed a commit
to pacrob/eth-account
that referenced
this pull request
Apr 26, 2023
pacrob
pushed a commit
to pacrob/eth-account
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for comments to PR #49, closes #81.
What was wrong?
Some doctests from
account.Account.encrypt(),account.Account.decrypt()andmessages.encode_defunct()were disabled (+SKIP) because they were failing.Issue #81
How was it fixed?
account.Account.encrypt()is now providing full deterministic input, including the input passwordaccount.Account.decrypt()pprint()for clean indentation matching and deterministic dictionary key orderingmessages.encode_defunct()usesto_hex()&to_bytes()frometh_utilsrather thanweb3Cute Animal Picture