Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorial): update example of multiple writes #908

Conversation

romainwg
Copy link
Contributor

This pull request addresses issue #901 by enhancing the "How to make multiple writes in a transaction" tutorial.

The update includes a new example that demonstrates how to perform multiple write operations within a single transaction.

This addition aims to improve the technical clarity and usefulness of the tutorial by providing a practical demonstration of executing a batch of operations, specifically multiple Put operations, in a single transaction.

This enhancement will help users better understand and implement this functionality in their own projects.

@k8s-ci-robot
Copy link

Hi @romainwg. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…tion to tutorial

see: etcd-io#901
Signed-off-by: Romain WALCH--GUINEBERT <[email protected]>
@romainwg romainwg force-pushed the docs/update-the-example-of-multiple-writes-transaction branch from f4527e2 to 6693c17 Compare October 12, 2024 13:52
@romainwg romainwg marked this pull request as draft October 28, 2024 07:25
@romainwg romainwg marked this pull request as ready for review October 28, 2024 07:25
@romainwg romainwg force-pushed the docs/update-the-example-of-multiple-writes-transaction branch from 6aca0d6 to e0cbb39 Compare October 29, 2024 18:10
@jmhbnz
Copy link
Member

jmhbnz commented Nov 11, 2024

/ok-to-test

…ites-transaction

Signed-off-by: Romain WALCH--GUINEBERT <[email protected]>
@romainwg
Copy link
Contributor Author

/ok-to-test

I've just synchronised the PR on main branch.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @romainwg

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, romainwg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit fc178bb into etcd-io:main Nov 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants