-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG: Fix runtime panic that occurs when KeepAlive is called with a Context implemented by an uncomparable type #18893 #18951
Conversation
Hi @ktalg. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 19 files with indirect coverage changes @@ Coverage Diff @@
## main #18951 +/- ##
==========================================
+ Coverage 68.66% 68.71% +0.04%
==========================================
Files 420 420
Lines 35563 35563
==========================================
+ Hits 24420 24437 +17
+ Misses 9711 9700 -11
+ Partials 1432 1426 -6 Continue to review full report in Codecov by Sentry.
|
Also please signoff the commit. Read https://github.com/etcd-io/etcd/pull/18951/checks?check_run_id=33536510903 |
9268acd
to
3337bec
Compare
…h a Context implemented by an uncomparable type etcd-io#18893 Signed-off-by: KT <[email protected]>
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ktalg
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, ktalg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#18893