NetworkClient - close the connection in stop() method #9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Hello JAndrassy, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
JAndrassy
force-pushed
the
networkclient_fix_stop
branch
from
aaf6cae
to
54dcb55
Compare
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
for all copies referring it
JAndrassy
force-pushed
the
networkclient_fix_stop
branch
from
54dcb55
to
9a9e719
Compare
|
Thanks for PR @JAndrassy, we will review it soon. |
|
@JAndrassy can you come up with a test case for this? Think of a sketch that would use multiple copies of the client and close when it should. The sketch should not require external libs |
|
the best example is an attempt to implement server.available() and print-to-all-clients in 'external library'. |
|
Status update:
|
|
the sketch above is an almost real world example. of course for a CI test a much simpler example would work |
|
a simple test: |
Hello @JAndrassy, can you please provide full small example which fails without your changes and work afterwards? |
|
|
Did you test the sketch you posted? We are still getting same result with/without PR changes. |
|
tested and retested now. the difference is, that without the PR it prints "still connected" |
My bad, I have my environment for testing set wrongly. Its fine now |
me-no-dev
approved these changes
May 10, 2024
me-no-dev
added
Status: Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR allows to close the TCP connection in
client.stop()for all copies of NetworkClient which wrap the same TCP connection.The existence of multiple copies of WiFiClient for the same TCP connection is a feature of the 'Arduino language' and the networking libraries must deal with it.
Destroy of a NetworkClient instance should not close the TCP connection unless it is the last copy handling that connection. Thanks to shared_ptr NetworkClientSocketHandle instance closes the connection as it is destroyed when the last copy of NetworkClient for that connection is destroyed.
tested with WiFiPagerServer example from my NetAPIHelpers library with this added: