Fixed typo for adc_continuous_data typedef in esp32-hal-adc.h/.c #9529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed typo in adc_continuous_data typedef
|
|
👋 Hello Darkl0ud, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
I'm brand new to commits, and really using GitHub for anything other than grabbing source. I'll look into all of this! |
P-R-O-C-H-Y
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Hi @Darkl0ud, Thank you for fixing that. Can you also fix it in documentation, example and test case?
Files where fix is needed:
- docs/en/api/adc.rst
- libraries/ESP32/examples/AnalogReadContinuous/AnalogReadContinuous.ino
- tests/periman/periman.ino
I can handle that if you want :)
|
Responding through Email. Not sure if this works.
I would love to fix the docs! I didn't even think about checking examples.
It was getting late for me and I wanted to get that commit out, and in my
haste I didn't check.
I'll fix if a bit later today!
…On Thu, Apr 18, 2024, 5:51 AM Jan Procházka ***@***.***> wrote:
***@***.**** commented on this pull request.
Hi @Darkl0ud <https://github.com/Darkl0ud>, Thank you for fixing that.
Can you also fix it in documentation, example and test case?
Files where fix is needed:
- docs/en/api/adc.rst
-
libraries/ESP32/examples/AnalogReadContinuous/AnalogReadContinuous.ino
- tests/periman/periman.ino
I can handle that if you want :)
—
Reply to this email directly, view it on GitHub
<#9529 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZBUFLB2TD7VVBOSA64T2TY56JRFAVCNFSM6AAAAABGMPECW6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMBYGM4TGNRXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks @Darkl0ud :) btw. you don't have to worry about the commit messages warnings. No need to redo that. |
|
Got it! And I do see that GitHubs email system allows for email replies. I
was rolling out of bed when I sent that. I just make a new commit with the
extra doc changes I assume? This is my first commit to a repo that I do not
maintain.
On Thu, Apr 18, 2024, 7:25 AM Jan Procházka ***@***.***>
wrote:
… Responding through Email. Not sure if this works. I would love to fix the
docs! I didn't even think about checking examples. It was getting late for
me and I wanted to get that commit out, and in my haste I didn't check.
I'll fix if a bit later today!
… <#m_3476288214209361210_>
On Thu, Apr 18, 2024, 5:51 AM Jan Procházka *@*.*> wrote: @.** commented
on this pull request. Hi @Darkl0ud <https://github.com/Darkl0ud>
https://github.com/Darkl0ud, Thank you for fixing that. Can you also fix
it in documentation, example and test case? Files where fix is needed: -
docs/en/api/adc.rst -
libraries/ESP32/examples/AnalogReadContinuous/AnalogReadContinuous.ino -
tests/periman/periman.ino I can handle that if you want :) — Reply to this
email directly, view it on GitHub <#9529 (review)
<#9529 (review)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACZBUFLB2TD7VVBOSA64T2TY56JRFAVCNFSM6AAAAABGMPECW6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMBYGM4TGNRXG4
. You are receiving this because you were mentioned.Message ID: *@*.***>
Thanks @Darkl0ud <https://github.com/Darkl0ud> :) btw. you don't have to
worry about the commit messages warnings. No need to redo that.
—
Reply to this email directly, view it on GitHub
<#9529 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZBUFLK34G4ONCLCWHI63LY56USVAVCNFSM6AAAAABGMPECW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRTGYZTOMJRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Yes, just do a commit with the changes. |
Additional commit for previous commit (espressif#9529) adding typo corrections within 1. /docs/en/api/adc.rst 2. /libraries/ESP32/examples/AnalogReadContinuous\AnalogReadContinuous.ino 3. tests/periman/periman.ino
|
Figured out that I can use VS Code to search within the whole repo and find the instances of "continuos", including within the docs. Everything should be committed. Thank you so much! |
Memory usage test (comparing PR agains master branch)The table below shows the summary of memory usage change (min - max) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Memory usage test (comparing PR agains master branch)The table below shows the summary of memory usage change (min - max) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typo in adc_continuous_data typedef
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Description of Change
Please describe your proposed Pull Request and it's impact.
A simple typo adjustment. It's impact is more clarity when developing. Less distraction.
Tests scenarios
Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)
Tested on ESP32-S3 while using ADC Continuous Mode to read off 4 pins at a time continuously while utilizing ISR after each conversion. Very close scenario to the example scenario.
Related links
Please provide links to related issue, PRs etc.
It's just a typo.