Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(openthread): add license declaration to all soure code and examples #10631

Merged
merged 1 commit into from
Nov 22, 2024
Merged

feat(openthread): add license declaration to all soure code and examples #10631

merged 1 commit into from
Nov 22, 2024

Conversation

SuGlider
Copy link
Collaborator

Description of Change

This PR adds License information to OpenThread source code and examples.

Tests scenarios

None - Just CI.

Related links

None.

@SuGlider SuGlider added the Type: Example Issue is related to specific example. label Nov 21, 2024
@SuGlider SuGlider added this to the 3.0.8 milestone Nov 21, 2024
@SuGlider SuGlider self-assigned this Nov 21, 2024
@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 62b789c

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

Test Results

 56 files   56 suites   4m 19s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit 62b789c.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Nov 21, 2024
@SuGlider SuGlider merged commit 3dd4b0d into espressif:master Nov 22, 2024
71 of 86 checks passed
@SuGlider SuGlider deleted the openthread_license branch November 22, 2024 14:57
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Nov 24, 2024
@Jason2866 @SuGlider
@lucasssvaz @NPaolini
Fix/networking
0122fc3 
* feat(openthread): add license declaration to all soure code and examples (espressif#10631)

* fix(network): Avoid returning zero if connection is not dropped

Co-authored-by: NPaolini <[email protected]>

---------

Co-authored-by: Rodrigo Garcia <[email protected]>
Co-authored-by: Lucas Saavedra Vaz <[email protected]>
Co-authored-by: NPaolini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@me-no-dev me-no-dev me-no-dev approved these changes

Assignees

@SuGlider SuGlider

Labels
Status: Pending Merge Pull Request is ready to be merged Type: Example Issue is related to specific example.
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@SuGlider @me-no-dev @lucasssvaz @P-R-O-C-H-Y