Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typo): Fix typo in CDC DFU flash tutorial #10584

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

jurstu
Copy link
Contributor

@jurstu jurstu commented Nov 8, 2024

Fixing a small typo

Checked the whole checklist, just fixing a typ0.

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update cdc_dfu_flash.rst":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update docs/en/tutorials/cdc_dfu_flash.rst":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update docs/en/tutorials/cdc_dfu_flash.rst":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello jurstu, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 73d941d

@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label Nov 8, 2024
@lucasssvaz lucasssvaz changed the title fix typo fix(typo): FIx typi in CDC DFU flash tutorial Nov 8, 2024
@lucasssvaz lucasssvaz changed the title fix(typo): FIx typi in CDC DFU flash tutorial fix(typo): FIx typo in CDC DFU flash tutorial Nov 8, 2024
@lucasssvaz lucasssvaz changed the title fix(typo): FIx typo in CDC DFU flash tutorial fix(typo): Fix typo in CDC DFU flash tutorial Nov 8, 2024
@jurstu
Copy link
Contributor Author

jurstu commented Nov 8, 2024

Do I need to do any action to move this forward?

@lucasssvaz
Copy link
Collaborator

Do I need to do any action to move this forward?

No. We will merge this soon.

@lucasssvaz lucasssvaz added the Status: Pending Merge Pull Request is ready to be merged label Nov 8, 2024
@me-no-dev me-no-dev merged commit 1a8e53f into espressif:master Nov 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants