-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UNOPTIMIZED] Sims-Flanagan High-Fidelity Leg Feature #38
Conversation
…. Minor typo fixes.
…ch and throttle constraint gradients with accompanying tests. Minor fixes.
…include various segment counts and cut ratios. Small formatting fixes.
…ble for identical interface to sf leg.
…flanagan_hf_dev
… fix with setting throttles. Resolved minor compiler complaints.
…on bindings but output is WIP.
…ow/kep3 into feature/sims_flanagan_hf_dev
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 98.10% 98.20% +0.09%
==========================================
Files 30 33 +3
Lines 1798 2116 +318
==========================================
+ Hits 1764 2078 +314
- Misses 34 38 +4
|
With the latest commit, I hope that this PR can be merged or at least reviewed in its entirety; the benchmark now performs more in line with expectations. The HF method is still slower by a factor of almost 20 for 5 segment legs with the analytical gradient, however, this improves for more legs to only a factor of 5. The numerical gradient is slower by a factor of 5 and improves to a factor of 2 for more legs. Below is the updated output of the benchmarks: Lower fidelity method
Higher fidelity method
|
Contents
Lower fidelity model
Higher fidelity model