Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waveregime internship #84

Merged
merged 123 commits into from
Apr 25, 2022
Merged

Waveregime internship #84

merged 123 commits into from
Apr 25, 2022

Conversation

torbjornstoro
Copy link
Collaborator

Description

Summary of changes

  • Implemented FDTD into NIDN

How Has This Been Tested?

  • Tested that FDTD works properly
  • Tested that the NIDN can use FDTD to learn correct epsilon values

gomezzz and others added 30 commits November 23, 2021 12:56
@gomezzz
Started preparing notebooks for paper
0675bab
@gomezzz
- Small plot improvements
fc75508 
- Added results for some of the simple examples
@gomezzz
Working filter NB and gt
ce327d2
@gomezzz
Added z-scaling to make layers more indepedent
15c0513
@gomezzz
Working on results, increased z scaling
5d1c910
@gomezzz
Added cfg option for other boundary layer eps
e6cd6ca
@gomezzz
Fixed plot ticks
60f72fb
@torbjornstoro
added compute spectrum file, which runs fdtd simulation and plots the…
5a674c8 
… transmission spectrum and reflectance spectrum
@gomezzz
(Torbjørn) Working on the plot spectrum
f4579fb
@torbjornstoro
Compute and plot spectrum from fdtd in separate file, and notebook wh…
adf9fbe 
…ich runs it
@gomezzz
Update run_tests.yml
0019f36 
Added running tests on waveregime-internship branch
@torbjornstoro
Merge branch 'compute_and_plot_spectrum' into WI-plot-spectrum
203b69e
@torbjornstoro
Removed unused code
b1a067c
@torbjornstoro
Improved readability of code, and implementing better standard for co…
34f9b54 
…ding, based on feedback from PR
@torbjornstoro
removed cache from notebook
421afb2
@torbjornstoro
Added black formatter, fixed some errors from previous commit. tested…
41168ef 
… in a separat notebook. Removed output from notebooks
@torbjornstoro
Merge pull request #46 from esa/WI-plot-spectrum
1dc8b92 
Working on the plot spectrum
@torbjornstoro
Created FDTD class
7087a9d
@torbjornstoro
Merge branch 'WI-plot-spectrum' into integrate_fdtd_in_nidn
68cbc01
@torbjornstoro
Created structure fr fdt class
8ebbd19
@torbjornstoro
Improving structure by splitting up functionalities inot different files
83372df
@torbjornstoro
Updated file that was missing in previous commit
c480c81
@torbjornstoro
First draft of completed files with docstrings, no testing performed yet
97bc2ec
@torbjornstoro
Update default_config.toml
b2db93e
@torbjornstoro
Saved changes before creating new branch
9efa683
@torbjornstoro
Merge branch 'integrate_fdtd_in_nidn' into WI_ensuring_runnable_code
e77490b
@torbjornstoro
Update default_config.toml
f00d103
@torbjornstoro
Merge pull request #47 from esa/integrate_fdtd_in_nidn
eef02ce 
Integrate fdtd in nidn
@torbjornstoro
Fixed up bugs in code such that code is runnable
a3b0789
@torbjornstoro
Fixed small errors
38ef13b
torbjornstoro and others added 23 commits April 20, 2022 12:09
@torbjornstoro
Merge pull request #77 from esa/WI_adding_ricker_wavelet
9f76397 
Wi adding ricker wavelet
@torbjornstoro
Merge branch 'waveregime-internship' into WI_notebook_examples
125d410
@torbjornstoro @gomezzz
Apply suggestions from code review
dbe5df7 
Co-authored-by: Pablo Gómez <[email protected]>
@torbjornstoro
Added support for N-layers > 1 and PER_LAYER_THICKNESS is only one en…
c9faf9a 
…try, as for TRCWA
@torbjornstoro
More updates on notebooks, not finished
f728381
@torbjornstoro
Merge branch 'WI_notebook_examples' of https://github.com/esa/NIDN in…
42ece72 
…to WI_notebook_examples
@torbjornstoro
Updated running and training notebooks with examples and instructions…
f0298fa 
… how they work, as well as removed an warning already covered elsewhere
@torbjornstoro
Made point source work aswell
58c8724
@torbjornstoro
Updated the docs, moved FDTD section and fixed bullet points
f48f6b6
@torbjornstoro
Fixed feedback on notebooks
4882b36
@torbjornstoro @gomezzz
Apply suggestions from code review
14c115d 
Co-authored-by: Pablo Gómez <[email protected]>
@gomezzz
WIP on paper notebooks
d60bcb2
@torbjornstoro
Merge pull request #78 from esa/WI_notebook_examples
f0ec337 
Added example notebooks for FDTD, one how to use on its own, and one …
@torbjornstoro
Minor update of the docs
197d49c
@torbjornstoro
Merge branch 'waveregime-internship' into WI_FDTD_notebooks
fd8d830
@gomezzz
Merge branch 'waveregime-internship' into Paper-Results
737fe09
@torbjornstoro
More explanations on parameters, adding more info on FDTD
fbd947c
@torbjornstoro
Minor grammar correction
78aeafc
@torbjornstoro
Moved FDTD section
4e4bb0b
@torbjornstoro @gomezzz
Apply suggestions from code review
4655264 
Co-authored-by: Pablo Gómez <[email protected]>
@torbjornstoro
Merge pull request #76 from esa/WI_FDTD_notebooks
8c8338d 
First draft of FDTD documentation
@gomezzz
Merge pull request #83 from esa/Paper-Results
7bbb92e 
Paper results
@gomezzz
hotfix for tests / CI
a7de78b
gomezzz
gomezzz approved these changes Apr 22, 2022
View reviewed changes
Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggest, pls apply if suitable. Note: If there any todos left inside FDTD please create issues for them now. I created #85 for that :)

nidn/fdtd/__init__.py Outdated Show resolved Hide resolved
nidn/fdtd/backend.py Outdated Show resolved Hide resolved
nidn/fdtd/backend.py Outdated Show resolved Hide resolved
nidn/fdtd/backend.py Outdated Show resolved Hide resolved
nidn/fdtd/backend.py Show resolved Hide resolved
nidn/utils/global_constants.py Outdated Show resolved Hide resolved
nidn/utils/global_constants.py Outdated Show resolved Hide resolved
@torbjornstoro torbjornstoro merged commit 8c4254b into main Apr 25, 2022
@torbjornstoro torbjornstoro deleted the waveregime-internship branch April 25, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomezzz gomezzz gomezzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torbjornstoro @gomezzz