Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our machines have 2 NUMA nodes, but only one is connected to the network. Hence, running eRPC on half of the cores is efficient, but the other half experience significant performance issues.
This pull request is inspired by the HERD architecture to use heap memory, when numa_node is set to -1.
https://github.com/efficient/rdma_bench/blob/master/libhrd/hrd_conn.c#L117
It is now possible to set numa_node as
erpc::kNoNumaNode
on the Nexus constructor so that NUMA memory is not used on eRPC. Obviously this ends up being slightly slower for when such nodes are available, but in our configuration this achieved a20.6%23.1% performance increase, so I believe it's a good option to have for eRPC.TODO:
Scaling up to kHugePageSize is unnecessary in this configuration, so to save memory it might be useful to avoid it.Update: It is still better to scale up in cases where buffer size varies between requests due to eRPC reusing buffers. This increased performance by 3%.
Add a test for this configuration.