Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes FN with #55

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes FN with #55

wants to merge 4 commits into from

Conversation

ahcorde
Copy link

@ahcorde ahcorde commented Apr 29, 2024

There are some changes in the lcov version

         FN:<line number of function start>,(<line number of function end>,)?<function name>

old version

         FN:<line number of function start>,<function name>

This should fix the issue and don't break user

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde mentioned this pull request Apr 29, 2024
@ahcorde
Copy link
Author

ahcorde commented Apr 30, 2024

@eriwen do you mind to take a look ?

@eriwen
Copy link
Owner

eriwen commented May 2, 2024

Hi @ahcorde, thank you for contributing. Could you please provide a test to verify this fix?

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Copy link
Author

ahcorde commented May 8, 2024

sure @eriwen, do you mind to take another look ? Thank you

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Copy link
Author

ahcorde commented May 13, 2024

@eriwen Let's run CI again

@ahcorde
Copy link
Author

ahcorde commented May 17, 2024

friendly ping @eriwen

2 similar comments
@ahcorde
Copy link
Author

ahcorde commented May 27, 2024

friendly ping @eriwen

@ahcorde
Copy link
Author

ahcorde commented Jun 11, 2024

friendly ping @eriwen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants