-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 1 #29
base: master
Are you sure you want to change the base?
Patch 1 #29
Conversation
xml.dom use too much memory, so converting big lcov file may result in memory error on memory limitated environment like jenkins. xml.etree will reduce memory usage to under 10~20% than xml.dom. But xml.etree not support prettyxml, so if you want to generate pretty xml, use xmllint.
If this is useless, let me know. |
I was also having issues with a large sample file (~128 MBs or so) which makes me want to test this... |
I rebased on master but now the diff tests are failing:
@doyou89 Please rebase your branch against master and try again? The tools are a bit nicer now; just install tox and run |
Well, it does work on the large file, and the
|
@sarnold thank you for check. Conflicts resolved, merge plz. |
@sarnold I had rebased my branch. merge plz. |
xml.dom use too much memory, so converting big lcov file may result in memory error on memory limitated environment like jenkins.
xml.etree will reduce memory usage to under 10~20% than xml.dom.
But xml.etree not support prettyxml, so if you want to generate pretty xml, use xmllint.