Updated Code: Temperature, Humidity, On-Demand Status Update #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Apr 24, 2013
ghost
commented
- Renamed temperature to target_temperature and current_temperature to temperature due to confusion. Both will work for changing the target temperature.
- Added target_humidity for read and write.
- Added update_status to retrieve the latest data from the server, saving it into self.status_json.
- Modified status to call update_status if self.status_json is not populated yet (which should not happen).
- Modified temperature= and humidity= to call update_status once the change is saved.
- Increased version to 0.0.5.
…o temperature due to confusion. Both will work for changing the target temperature. * Added target_humidity for read and write. * Added update_status to retrieve the latest data from the server, saving it into self.status_json. * Modified status to call update_status if self.status_json is not populated yet (which should not happen). * Modified temperature= and humidity= to call update_status once the change is saved. * Increased version to 0.0.5.
|
Looks like there's several changes here, I'll need to review this in more detail to verify it all works. Also I'll need to add tests. |
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.