-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Multiple Structure and Device support #12
base: master
Are you sure you want to change the base?
Conversation
… it work with smoke detectors
…loading of structures/devices as those are not as likely to change
(tests are included) |
@stevenpetryk I'd love to see this merged. It needs some love especially with the new changes you've intro'd. |
Is that outside the scope of this gem? I mean, this is the only gem I can find designed for interacting with Nest at all, and it WOULD be nice for it to work with Nest Protect, but the name of the gem is |
I think we'll make separate gems for that. I plan on getting a nest protect in the next 2-3 months. A core api gem could be good too. |
i can fix the merge if you guys like and remove the todo. I was planning on getting nest protect as well to implement |
Just FYI, if you're registered as a Nest developer (it's free), you can add a fake device to your account using the Nest Developer Chrome plugin. That's what I've been doing, since I don't actually have a Nest thermostat. |
Oh nice, cheers forthat |
Also, @ericboehs, this was mentioned in passing by @fuelxc, but I'm a huge fan of changing the namespace to |
That sounds like a great idea. Feel free to add off topic comments in gitter. |
Added models Structure and Device.
Allows for multiples of each and setters can be called on nest/structure and will affect all the children
Do to the new models I added in a flag for initializing structures.
Refactored a bit of the initialization of Nest in order to help this refreshing.
Looking to go get a smoke alarm to so that we can subclass devices into thermostat and smoke alarm. Might consider changing the namespace at that time off of NestThermostat to Nest and changing Nest to Account