Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure client certificate mode #80

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

kov117
Copy link
Contributor

@kov117 kov117 commented Nov 21, 2024

Checklist

  • I've updated both the azurerm_linux_function_app and azurerm_windows_function_app resources.

@kov117 kov117 added the enhancement New feature or request label Nov 21, 2024
@kov117 kov117 self-assigned this Nov 21, 2024
@kov117
Copy link
Contributor Author

kov117 commented Nov 21, 2024

Test pass 🎆

@kov117 kov117 marked this pull request as ready for review November 21, 2024 13:49
@kov117 kov117 requested a review from a team as a code owner November 21, 2024 13:49
@hknutsen
Copy link
Member

Have a look at descriptions and default values for variables client_certificate_mode and client_certificate_enabled in this PR: equinor/terraform-azurerm-web-app/pull/215

Should probably go for a similar implementation here 🙂

@kov117
Copy link
Contributor Author

kov117 commented Nov 22, 2024

agreed and appreciated for the heads up 🫶

@kov117
Copy link
Contributor Author

kov117 commented Nov 22, 2024

Ran a new test and it passed 👍🏼

@kov117
Copy link
Contributor Author

kov117 commented Nov 25, 2024

Passed the test 👍🏼

@hknutsen hknutsen changed the title feat: configure for client certificate mode feat: configure client certificate mode Nov 25, 2024
@hknutsen
Copy link
Member

I think this looks good now, however the client_certificate_mode argument has no effect without the client_certificate_enabled argument. We should have a variable for that as well (see link to relevant PR in my previous comment).

@kov117
Copy link
Contributor Author

kov117 commented Nov 25, 2024

Noted, should i include it to the tftest config as well ?

@hknutsen
Copy link
Member

Noted, should i include it to the tftest config as well ?

I think yes 👍

@kov117
Copy link
Contributor Author

kov117 commented Nov 25, 2024

Test passed 👍🏼

tests/certificate.unit.tftest.hcl Outdated Show resolved Hide resolved
tests/certificate.unit.tftest.hcl Outdated Show resolved Hide resolved
tests/certificate.unit.tftest.hcl Outdated Show resolved Hide resolved
tests/certificate.unit.tftest.hcl Outdated Show resolved Hide resolved
tests/certificate.unit.tftest.hcl Outdated Show resolved Hide resolved
tests/certificate.unit.tftest.hcl Outdated Show resolved Hide resolved
tests/defaults.unit.tftest.hcl Outdated Show resolved Hide resolved
tests/defaults.unit.tftest.hcl Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
kov117 and others added 7 commits November 25, 2024 12:44
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
kov117 and others added 3 commits November 25, 2024 12:45
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
@kov117 kov117 requested a review from a team November 25, 2024 11:46
@hknutsen
Copy link
Member

@kov117 some of the windows_client_certificate_* tests refer to the azurerm_linux_function_app resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants