Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Bip Bop - Fusion Framework Release #2525

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 1, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@equinor/[email protected]

Patch Changes

  • #2524 1941b76 Thanks @odinr! - Fixed LegacyAuthContainer.registerAppAsync to not create duplicate AuthApps when additional resources are added to the app.

  • #2524 1941b76 Thanks @odinr! - Fixed createServiceResolver to extract app client id from each services.
    Previously we assumed that all services registered to the legacy auth container would use the same scope as all other services. This is not the case, as each service can have its own scope. This change allows us to extract the client id from the service definition, which is then used to create the service resolver.

    Resources are indexed by the client id, so when acquiring a resource, the legacy auth container will use the client id to generate an auth token. This token is then used to authenticate the request to the resource.

    NOTE: This will and should be deprecated in the future! This "bug" was discovered while an application used a mixed of legacy and new Framework, which caused the application to fail to authenticate requests to the resource (wrong audience).

@github-actions github-actions bot requested review from odinr and a team as code owners November 1, 2024 12:49
@github-actions github-actions bot marked this pull request as draft November 1, 2024 12:49
@odinr odinr marked this pull request as ready for review November 1, 2024 12:49
@odinr odinr merged commit 749f915 into main Nov 1, 2024
4 of 5 checks passed
@odinr odinr deleted the changeset-release/main branch November 1, 2024 12:50
@github-actions github-actions bot added 👾 React 📚 documentation Improvements or additions to documentation labels Nov 1, 2024
Copy link
Contributor Author

github-actions bot commented Nov 1, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.39% 1746 / 440987
🔵 Statements 0.39% 1746 / 440987
🔵 Functions 23.8% 219 / 920
🔵 Branches 37.34% 400 / 1071
File CoverageNo changed files found.
Generated in workflow #7904 for commit 0d1a517 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation 👾 React
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant